fix: account for clock drift in certificate freshness check #1081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
4 tasks
nathanosdev
reviewed
Jul 29, 2025
nathanosdev
approved these changes
Jul 29, 2025
mraszyk
reviewed
Aug 4, 2025
mraszyk
reviewed
Aug 4, 2025
This reverts commit 9f8ed1f.
mraszyk
reviewed
Aug 4, 2025
mraszyk
reviewed
Aug 4, 2025
Co-authored-by: mraszyk <31483726+mraszyk@users.noreply.github.com>
mraszyk
approved these changes
Aug 4, 2025
Co-authored-by: mraszyk <31483726+mraszyk@users.noreply.github.com>
nathanosdev
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Accounts for the clock drift between the current time and the IC network time when checking the certificate freshness. Adds some helper methods and functions, check the updated changelog for a list of all the changes.
Additionally, fixes #686.
How Has This Been Tested?
Added unit tests to check the new clock drift adjustments in the certificate verification.
Checklist: