feat: add getBalance to BTC package #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonioVentilii-DFINITY
changed the title
size-limit report 📦
|
WDYT?
|
|
Sounds good |
AntonioVentilii-DFINITY
deleted the
feature/add-get-balance-to-btc-package
branch
peterpeterparker
added a commit
that referenced
this pull request
Aug 27, 2024
# Motivation As discussed in #701, let's rename `min_confirmations` parameter of `getUtxos` in ckBTC library to `minConfirmations`. # Changes - Parameter and mapping updated accordingly. --------- Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
AntonioVentilii-DFINITY
added a commit
that referenced
this pull request
Aug 27, 2024
# Motivation As discussed in #701, let's rename `min_confirmations` parameter of `getBalance` in ckBTC library to `minConfirmations`. # Changes - Parameter and mapping updated accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Expose function getBalance, used to retrieve the balance of a Bitcoin address given a network and, optionally, a minimum number of confirmations.
Changes
bigintnumber identified by the typesatoshi).get_balancefrom the canister into new functiongetBalanceof objectBitcoinCanister.Tests
Create set of test mirroring the ones used for
getUtxosfunction.