Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ckBTC min_confirmations renamed to minConfirmations #703

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

peterpeterparker
Copy link
Member

Motivation

As discussed in #701, let's rename min_confirmations parameter of getUtxos in ckBTC library to minConfirmations.

Changes

  • Parameter and mapping updated accordingly.

Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
Copy link
Contributor

github-actions bot commented Aug 26, 2024

size-limit report 📦

Path Size
@dfinity/ckbtc 8 KB (+0.52% 🔺)
@dfinity/cketh 3.45 KB (0%)
@dfinity/cmc 1.29 KB (0%)
@dfinity/ledger-icrc 3.89 KB (0%)
@dfinity/ledger-icp 15.23 KB (0%)
@dfinity/nns 36.62 KB (0%)
@dfinity/nns-proto 140.98 KB (0%)
@dfinity/sns 15.92 KB (0%)
@dfinity/utils 4.5 KB (0%)
@dfinity/ic-management 2.92 KB (0%)

Copy link
Contributor

@AntonioVentilii-DFINITY AntonioVentilii-DFINITY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the end, I left min_confirmations in getBalance too, just to be consistent, thinking that we would change everything together in another PR. Shall we change it here too? Or separate PR?

CHANGELOG.md Show resolved Hide resolved
@peterpeterparker
Copy link
Member Author

In the end, I left min_confirmations in getBalance too, just to be consistent, thinking that we would change everything together in another PR. Shall we change it here too? Or separate PR?

@AntonioVentilii-DFINITY oh! yeah in another PR. No need to add anything in CHANGELOG as it is not yet released but for separation of concern, let's split in another PR. Works for you?

Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker peterpeterparker merged commit 79675d0 into main Aug 27, 2024
11 checks passed
@peterpeterparker peterpeterparker deleted the feat/min-confirmations branch August 27, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants