Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rename optional param of getBalance #704

Merged
merged 1 commit into from
Aug 27, 2024
Merged

refactor: rename optional param of getBalance #704

merged 1 commit into from
Aug 27, 2024

Conversation

AntonioVentilii-DFINITY
Copy link
Contributor

Motivation

As discussed in #701, let's rename min_confirmations parameter of getBalance in ckBTC library to minConfirmations.

Changes

  • Parameter and mapping updated accordingly.

@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size
@dfinity/ckbtc 8 KB (0%)
@dfinity/cketh 3.45 KB (0%)
@dfinity/cmc 1.29 KB (0%)
@dfinity/ledger-icrc 3.89 KB (0%)
@dfinity/ledger-icp 15.23 KB (0%)
@dfinity/nns 36.62 KB (0%)
@dfinity/nns-proto 140.98 KB (0%)
@dfinity/sns 15.92 KB (0%)
@dfinity/utils 4.5 KB (0%)
@dfinity/ic-management 2.92 KB (0%)

peterpeterparker
peterpeterparker approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@peterpeterparker peterpeterparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@AntonioVentilii-DFINITY AntonioVentilii-DFINITY merged commit 0dd5c19 into main Aug 27, 2024
11 checks passed
@AntonioVentilii-DFINITY AntonioVentilii-DFINITY deleted the refactor/rename-optional-param-of-get-balance branch August 27, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterpeterparker peterpeterparker peterpeterparker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AntonioVentilii-DFINITY @peterpeterparker @AntonioVentilii