Fix-failing-disability-compensation-test-on-master #14675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stiehlrod
approved these changes
Nov 29, 2023
Tonksthebear
pushed a commit
that referenced
this pull request
Dec 1, 2023
* Rolls back a REGEX update that is causing a failing validation when it shouldn't be. Changes to be committed: modified: modules/claims_api/config/schemas/v2/526.json modified: modules/claims_api/spec/requests/v2/veterans/disability_compensation_request_spec.rb
lindluni
pushed a commit
that referenced
this pull request
Dec 1, 2023
* Rolls back a REGEX update that is causing a failing validation when it shouldn't be. Changes to be committed: modified: modules/claims_api/config/schemas/v2/526.json modified: modules/claims_api/spec/requests/v2/veterans/disability_compensation_request_spec.rb
acovrig
added a commit
that referenced
this pull request
Dec 4, 2023
acovrig
added a commit
that referenced
this pull request
Dec 4, 2023
* Fix some fields that weren't nullable * Make the fields !required in our manual validation * Update description in docs * Add missing swagger changes from #14675
allisonlu
pushed a commit
that referenced
this pull request
Dec 6, 2023
* Fix some fields that weren't nullable * Make the fields !required in our manual validation * Update description in docs * Add missing swagger changes from #14675
Thrillberg
pushed a commit
that referenced
this pull request
Feb 2, 2024
* Add additional logs to Pension submission (#14593) * API-31005 Handle null AOD in Caseflow appeals response (#14669) * Fix-failing-disability-compensation-test-on-master (#14675) * Rolls back a REGEX update that is causing a failing validation when it shouldn't be. Changes to be committed: modified: modules/claims_api/config/schemas/v2/526.json modified: modules/claims_api/spec/requests/v2/veterans/disability_compensation_request_spec.rb * Adds trace service tag to new LH veteran module controllers (#14617) * Create a Sidekiq job to pull in the OGC XLS/CSV file#68646 (#14632) * wip * add missing logic to QueueAddressUpdates * clean up UpdateAddresses * add roo gem * mock fetch_github_access_token * add tests for UpdateAddresses * add tests for QueueAddressUpdates * clean up xlsx_file_fetcher_spec.rb * add error handling * add error handling * set id var * rubocop UpdateAddresses * rubocop QueueAddressUpdates * rubocop XlsxFileFetcher * rubocop RSpec.describe RepOrgAddresses::QueueAddressUpdates * rubocop RSpec.describe Veteran::Service::UpdateAddresses * rubocop RSpec.describe RepOrgAddresses::XlsxFileFetcher * debugging - must fix tests * debug class - must fix tests * fix namespacing - debug * handle edge cases with zip codes * fix bug with handling zip codes * handle VSOs instead of representatives in QueueAddressUpdates * rubcop build_common_data (ugly - must refactor) * refactor QueueAddressUpdates#build_common_data * add #build_data_for_vsos and handle fake null values and empty strings * rubocop * rename var * reorder methods * update UpdateAddresses while running code in staging pod terminal * add RepOrgAddresses::QueueAddressUpdates to periodic_jobs.rb * update XlsxFileFetcher spec file * rubocop Gemfile * add batch description for each sheet that's processed * create mock xlsx file for testing * start rewriting specs for RepOrgAddresses::QueueAddressUpdates job * add comments re additional tests * update address spec fixups * rubocop QueueAddressUpdates * fix most rubocop issues in QueueAddressUpdates spec * rubocop modules/veteran/spec/sidekiq/rep_org_addresses/xlsx_file_fetcher_spec.rb * refactor tests due to "Do not stub methods of the object under test" cop * add code comments to QueueAddressUpdates * add code comments to UpdateAddresses * update #log_error in QueueAddressUpdates * update comments in queue_address_updates_spec.rb * add code comments to XlsxFileFetcher * rubocop * update value for xlsx_file_fetcher.github_access_token in settings.yml * remove periodic job for now --------- Co-authored-by: Jonathan VanCourt <jonathan.vancourt@adhocteam.us> * MHV-52038 Bypassing FHIR cache for vaccine list call (#14672) --------- Co-authored-by: Tai Wilkin-Corraggio <tai.wilkin@coforma.io> Co-authored-by: Casey Williams <caseywilliams@users.noreply.github.com> Co-authored-by: Rockwell Windsor Rice <129893414+rockwellwindsor-va@users.noreply.github.com> Co-authored-by: Patrick Vinograd <Patrick.Vinograd@va.gov> Co-authored-by: Holden Hinkle <holden@holdenhinkle.com> Co-authored-by: Jonathan VanCourt <jonathan.vancourt@adhocteam.us> Co-authored-by: Mike Moyer <87040148+mmoyer-va@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rolls back a REGEX update that is causing a failing validation when it shouldn't be.
Basically just a revert of API-31426.
Related issue(s)
Failing test on master
Testing done
Screenshots
Note: Optional
What areas of the site does it impact?
Acceptance criteria