Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MHV-52038 Bypassing FHIR cache for vaccine list call #14672

Merged
merged 0 commits into from
Nov 29, 2023

Conversation

mmoyer-va
Copy link
Contributor

@mmoyer-va mmoyer-va commented Nov 29, 2023

Summary

Quick fix to bypass cache when loading vaccines. We've already done this for allergies.

Related issue(s)

MHV-52038 - Implement feature flags and content for Vaccines Phase 0

We will need a feature flag for the Vaccines Domain and also one for the SideNav.

Re-implement the Sidenav.

Add any vaccines-specific content for Phase 0.

Audit done by Lexi -see below or slack https://dsva.slack.com/archives/C03Q2UQL1AS/p1700697692642599?thread_ts=1700697683.614639&cid=C03Q2UQL1AS

Landing page (all accordions expanded)
Adjust all content to fill full width of page
Add left nav menu back to desktop; “In this section” menu back to mobile
Add Vaccines section back to page. Change the Primary Action Link (with the green icon) to the secondary Action Link (with the blue icon) for the domain sections.
Update content of ‘How too find your other medical records’ section.
Update content of “What if I can’t find all my…” accordion title and section
List page
Update content of Intro paragraph
Cards: Added “Date received: ” in front of the date
Cards: Removed location field
Update pagination component to V3
Details page
Added “Vaccines: ” before the vaccine name to all vaccine details page H1’s
Update content under H1 to “Date received: [date]”
Removed the Manufacturer field (may return in Phase 1)
Removed the Reaction field (may return in Phase 1)
PDF (List)
Update content of Intro paragraph (This content intentionally does not match the web view)
Removed the Reaction field (may return in Phase 1)
PDF (Details page)
Added “Vaccines: ” to H1 before the vaccine name
Removed the Reaction field (may return in Phase 1)
There are also a few issues I noticed in Staging that will be surfaced in the upcoming UCD audit but y'all could probably get a head start:
The breadcrumbs on all are wonky. Refer to the mocks for the correct format.
The field label+data in the cards on the list page should be side-by-side, not stacked vertically
The text style of the field labels on the details page should be body-bold (not lead/intro text)
The fields in the printed reports and the downloaded reports are kind of wonky

Testing done

There is already an existing test for the cache-bypass functionality.

Screenshots

Note: Optional

What areas of the site does it impact?

MHV Medical Records

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@va-vsp-bot va-vsp-bot requested a deployment to MHV-52038-bypass-cache-vaccines/main/main November 29, 2023 15:16 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to MHV-52038-bypass-cache-vaccines/main/main November 29, 2023 15:17 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to MHV-52038-bypass-cache-vaccines/main/main November 29, 2023 15:30 Inactive
Copy link
Contributor

@tynyttie tynyttie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@va-vsp-bot va-vsp-bot requested a deployment to MHV-52038-bypass-cache-vaccines/main/main November 29, 2023 16:15 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to MHV-52038-bypass-cache-vaccines/main/main November 29, 2023 16:45 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to MHV-52038-bypass-cache-vaccines/main/main November 29, 2023 17:55 In progress
@mmoyer-va mmoyer-va marked this pull request as ready for review November 29, 2023 18:06
@mmoyer-va mmoyer-va requested review from a team November 29, 2023 18:06
@mmoyer-va mmoyer-va merged this pull request into master Nov 29, 2023
@mmoyer-va mmoyer-va deleted the MHV-52038-bypass-cache-vaccines branch November 29, 2023 18:22
Thrillberg pushed a commit that referenced this pull request Feb 2, 2024
* Add additional logs to Pension submission (#14593)

* API-31005 Handle null AOD in Caseflow appeals response (#14669)

* Fix-failing-disability-compensation-test-on-master (#14675)

* Rolls back a REGEX update that is causing a failing validation when it shouldn't be.
Changes to be committed:
	modified:   modules/claims_api/config/schemas/v2/526.json
	modified:   modules/claims_api/spec/requests/v2/veterans/disability_compensation_request_spec.rb

* Adds trace service tag to new LH veteran module controllers (#14617)

* Create a Sidekiq job to pull in the OGC XLS/CSV file#68646 (#14632)

* wip

* add missing logic to QueueAddressUpdates

* clean up UpdateAddresses

* add roo gem

* mock fetch_github_access_token

* add tests for UpdateAddresses

* add tests for QueueAddressUpdates

* clean up xlsx_file_fetcher_spec.rb

* add error handling

* add error handling

* set id var

* rubocop UpdateAddresses

* rubocop QueueAddressUpdates

* rubocop XlsxFileFetcher

* rubocop RSpec.describe RepOrgAddresses::QueueAddressUpdates

* rubocop RSpec.describe Veteran::Service::UpdateAddresses

* rubocop RSpec.describe RepOrgAddresses::XlsxFileFetcher

* debugging - must fix tests

* debug class - must fix tests

* fix namespacing - debug

* handle edge cases with zip codes

* fix bug with handling zip codes

* handle VSOs instead of representatives in QueueAddressUpdates

* rubcop build_common_data (ugly - must refactor)

* refactor QueueAddressUpdates#build_common_data

* add #build_data_for_vsos and handle fake null values and empty strings

* rubocop

* rename var

* reorder methods

* update UpdateAddresses while running code in staging pod terminal

* add RepOrgAddresses::QueueAddressUpdates to periodic_jobs.rb

* update XlsxFileFetcher spec file

* rubocop Gemfile

* add batch description for each sheet that's processed

* create mock xlsx file for testing

* start rewriting specs for RepOrgAddresses::QueueAddressUpdates job

* add comments re additional tests

* update address spec fixups

* rubocop QueueAddressUpdates

* fix most rubocop issues in QueueAddressUpdates spec

* rubocop modules/veteran/spec/sidekiq/rep_org_addresses/xlsx_file_fetcher_spec.rb

* refactor tests due to "Do not stub methods of the object under test" cop

* add code comments to QueueAddressUpdates

* add code comments to UpdateAddresses

* update #log_error in QueueAddressUpdates

* update comments in queue_address_updates_spec.rb

* add code comments to XlsxFileFetcher

* rubocop

* update value for xlsx_file_fetcher.github_access_token in settings.yml

* remove periodic job for now

---------

Co-authored-by: Jonathan VanCourt <jonathan.vancourt@adhocteam.us>

* MHV-52038 Bypassing FHIR cache for vaccine list call (#14672)

---------

Co-authored-by: Tai Wilkin-Corraggio <tai.wilkin@coforma.io>
Co-authored-by: Casey Williams <caseywilliams@users.noreply.github.com>
Co-authored-by: Rockwell Windsor Rice <129893414+rockwellwindsor-va@users.noreply.github.com>
Co-authored-by: Patrick Vinograd <Patrick.Vinograd@va.gov>
Co-authored-by: Holden Hinkle <holden@holdenhinkle.com>
Co-authored-by: Jonathan VanCourt <jonathan.vancourt@adhocteam.us>
Co-authored-by: Mike Moyer <87040148+mmoyer-va@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants