API-32066 Fix some fields that weren't nullable (#14721)

* Fix some fields that weren't nullable * Make the fields !required in our manual validation * Update description in docs * Add missing swagger changes from #14675
department-of-veterans-affairs · Dec 4, 2023 · d98701b · d98701b
1 parent 70fe9b1
commit d98701b
Show file tree

Hide file tree

Showing 4 changed files with 51 additions and 38 deletions.
diff --git a/...s/claims_api/app/controllers/concerns/claims_api/v2/disability_compensation_validation.rb b/...s/claims_api/app/controllers/concerns/claims_api/v2/disability_compensation_validation.rb
@@ -6,7 +6,6 @@ module ClaimsApi
   module V2
     module DisabilityCompensationValidation # rubocop:disable Metrics/ModuleLength
       include DisabilityCompensationSharedServiceModule
-
       DATE_FORMATS = {
         10 => 'yyyy-mm-dd',
         7 => 'yyyy-mm',
@@ -54,22 +53,10 @@ def validate_form_526_change_of_address!
       def validate_form_526_change_of_address_required_fields!
         change_of_address = form_attributes['changeOfAddress']
         coa_begin_date = change_of_address&.dig('dates', 'beginDate') # we can have a valid form without an endDate
-        coa_type_of_address_change = change_of_address&.dig('typeOfAddressChange')
-        coa_number_and_street = change_of_address&.dig('addressLine1')
-        coa_country = change_of_address&.dig('country')
 
         form_object_desc = 'change of address'
 
         raise_exception_if_value_not_present('begin date', form_object_desc) if coa_begin_date.blank?
-        if coa_type_of_address_change.blank?
-          raise_exception_if_value_not_present('type of address change',
-                                               form_object_desc)
-        end
-        if coa_number_and_street.blank?
-          raise_exception_if_value_not_present('number and street',
-                                               form_object_desc)
-        end
-        raise_exception_if_value_not_present('country', form_object_desc) if coa_country.blank?
       end
 
       def validate_form_526_change_of_address_beginning_date!
@@ -105,10 +92,10 @@ def validate_form_526_change_of_address_ending_date!
       end
 
       def validate_form_526_change_of_address_country!
-        change_of_address = form_attributes['changeOfAddress']
-        return if valid_countries.include?(change_of_address['country'])
+        country = form_attributes.dig('changeOfAddress', 'country')
+        return if country.nil? || valid_countries.include?(country)
 
-        raise ::Common::Exceptions::InvalidFieldValue.new('changeOfAddress.country', change_of_address['country'])
+        raise ::Common::Exceptions::InvalidFieldValue.new('changeOfAddress.country', country)
       end
 
       def validate_form_526_claimant_certification!
@@ -456,7 +443,7 @@ def validate_treated_disability_names!(treatments)
       def collect_treated_disability_names(treatments)
         names = []
         treatments.each do |treatment|
-          treatment['treatedDisabilityNames'].each do |disability_name|
+          treatment['treatedDisabilityNames']&.each do |disability_name|
             names << disability_name.strip.downcase
           end
         end
@@ -835,6 +822,7 @@ def raise_exception_on_invalid_account_values(account_detail)
 
       def validate_account_values!
         direct_deposit_account_vals = form_attributes['directDeposit']
+        return if direct_deposit_account_vals['noAccount']
 
         valid_account_types = %w[CHECKING SAVINGS]
         account_type = direct_deposit_account_vals&.dig('accountType')