[WIP] build: add cargo feature to drop various tools #8381
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Update: When building with
|
ry
reviewed
Dec 1, 2020
| @@ -135,8 +135,8 @@ impl DiagnosticBuffer { | |||
| #[derive(Debug, Clone)] | |||
| pub struct ErrorBuffer(Arc<RwLock<Vec<Diagnostic>>>); | |||
|
|
|||
| impl ErrorBuffer { | |||
| pub fn new() -> Self { | |||
There was a problem hiding this comment.
aside: shouldn't this result in a clippy error currently?
There was a problem hiding this comment.
I would expect so, but it seems that's only the case when having lib.rs
|
Closing in favor of #8640 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is really a prototype and is not intended to be landed.
This commit adds default cargo feature called "tools". When building with
--no-default-featuresflag most of the tools included in the regular binary won't be included (TS support, doc generator, formatter, linter, bundler, file watcher) and produced binary will be able to load file only from local disk (so effectively no URL support and only "deno run" subcommand is operational). This reduces binary size from about 45Mb to 30Mb (on macOS).There are still about 50 "unused" warnings left.
To try out locally: