more feature gating

cli/Cargo.toml

@@ -15,8 +15,8 @@ name = "deno"
 path = "main.rs"
 
 [features]
-default = ["deno_doc","deno_lint","dprint-plugin-typescript", "swc_bundler", "swc_ecmascript", "swc_common", "jsonc-parser"]
-no_tools = []
+tools = ["deno_doc","deno_lint","dprint-plugin-typescript", "swc_bundler", "swc_ecmascript", "swc_common", "jsonc-parser"]
+default = ["tools"]
 
 [[bench]]
 name = "deno_bench"

cli/errors.rs

@@ -9,7 +9,7 @@
 //!   Diagnostics are compile-time type errors, whereas JsErrors are runtime
 //!   exceptions.
 
-#[cfg(not(feature="no_tools"))]
+#[cfg(feature="tools")]
 use crate::ast::DiagnosticBuffer;
 use crate::import_map::ImportMapError;
 use deno_core::error::AnyError;
@@ -147,7 +147,7 @@ fn get_serde_json_error_class(
   }
 }
 
-#[cfg(not(feature="no_tools"))]
+#[cfg(feature="tools")]
 fn get_diagnostic_class(_: &DiagnosticBuffer) -> &'static str {
   "SyntaxError"
 }
@@ -211,10 +211,10 @@ pub(crate) fn get_error_class_name(e: &AnyError) -> &'static str {
         .map(get_serde_json_error_class)
     })
     .or_else(|| {
-      #[cfg(not(feature="no_tools"))]
+      #[cfg(feature="tools")]
       let maybe_get_error = || e.downcast_ref::<DiagnosticBuffer>().map(get_diagnostic_class);
 
-      #[cfg(feature="no_tools")]
+      #[cfg(not(feature="tools"))]
       let maybe_get_error = || Option::<&'static str>::None;
 
       (maybe_get_error)()

cli/inspector.rs

@@ -821,6 +821,7 @@ impl Future for DenoInspectorSession {
 
 /// A local inspector session that can be used to send and receive protocol messages directly on
 /// the same thread as an isolate.
+#[cfg(feature="tools")]
 pub struct InspectorSession {
   v8_channel: v8::inspector::ChannelBase,
   v8_session: v8::UniqueRef<v8::inspector::V8InspectorSession>,
@@ -829,19 +830,22 @@ pub struct InspectorSession {
   notification_queue: Vec<Value>,
 }
 
+#[cfg(feature="tools")]
 impl Deref for InspectorSession {
   type Target = v8::inspector::V8InspectorSession;
   fn deref(&self) -> &Self::Target {
     &self.v8_session
   }
 }
 
+#[cfg(feature="tools")]
 impl DerefMut for InspectorSession {
   fn deref_mut(&mut self) -> &mut Self::Target {
     &mut self.v8_session
   }
 }
 
+#[cfg(feature="tools")]
 impl v8::inspector::ChannelImpl for InspectorSession {
   fn base(&self) -> &v8::inspector::ChannelBase {
     &self.v8_channel
@@ -880,6 +884,7 @@ impl v8::inspector::ChannelImpl for InspectorSession {
   fn flush_protocol_notifications(&mut self) {}
 }
 
+#[cfg(feature="tools")]
 impl InspectorSession {
   const CONTEXT_GROUP_ID: i32 = 1;
 

cli/js.rs

@@ -6,21 +6,21 @@ pub const TS_VERSION: &str = env!("TS_VERSION");
 
 pub static CLI_SNAPSHOT: &[u8] =
   include_bytes!(concat!(env!("OUT_DIR"), "/CLI_SNAPSHOT.bin"));  
-#[cfg(not(feature="no_tools"))]
+#[cfg(feature="tools")]
 pub static COMPILER_SNAPSHOT: &[u8] =
   include_bytes!(concat!(env!("OUT_DIR"), "/COMPILER_SNAPSHOT.bin"));
-#[cfg(not(feature="no_tools"))]
+#[cfg(feature="tools")]
 pub static DENO_NS_LIB: &str = include_str!("dts/lib.deno.ns.d.ts");
-#[cfg(not(feature="no_tools"))]
+#[cfg(feature="tools")]
 pub static DENO_WEB_LIB: &str = include_str!(env!("DENO_WEB_LIB_PATH"));
-#[cfg(not(feature="no_tools"))]
+#[cfg(feature="tools")]
 pub static DENO_FETCH_LIB: &str = include_str!(env!("DENO_FETCH_LIB_PATH"));
-#[cfg(not(feature="no_tools"))]
+#[cfg(feature="tools")]
 pub static SHARED_GLOBALS_LIB: &str =
   include_str!("dts/lib.deno.shared_globals.d.ts");
-#[cfg(not(feature="no_tools"))]
+#[cfg(feature="tools")]
 pub static WINDOW_LIB: &str = include_str!("dts/lib.deno.window.d.ts");
-#[cfg(not(feature="no_tools"))]
+#[cfg(feature="tools")]
 pub static UNSTABLE_NS_LIB: &str = include_str!("dts/lib.deno.unstable.d.ts");
 
 pub fn deno_isolate_init() -> Snapshot {
@@ -29,7 +29,7 @@ pub fn deno_isolate_init() -> Snapshot {
   Snapshot::Static(data)
 }
 
-#[cfg(not(feature="no_tools"))]
+#[cfg(feature="tools")]
 pub fn compiler_isolate_init() -> Snapshot {
   debug!("Deno compiler isolate init with snapshots.");
   let data = COMPILER_SNAPSHOT;