refactor(cli): reorganize main.rs and split workers #8495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
changed the title
ry
reviewed
Nov 26, 2020
| } | ||
| DenoSubcommand::Types => { | ||
| let types = get_types(flags.unstable); | ||
| if let Err(e) = write_to_stdout_ignore_sigpipe(types.as_bytes()) { | ||
| eprintln!("{}", e); | ||
| std::process::exit(1); | ||
| } | ||
| return; | ||
| std::process::exit(0); |
There was a problem hiding this comment.
this fine for now, but ideally we would architect it so that exit is not called deeper inside the system
There was a problem hiding this comment.
Agreed, I'm still looking for proper patterns
ry
reviewed
Nov 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factored out
init_v8_flags,init_loggerandget_subcommandfrommainfunction.Also
Workerwas removed in favor of moving logic toMainWorkerandWebWorkerrespectively.
Towards #8381