Patch 1.6.1 #699

rishabhatdell · 2024-09-24T11:09:33Z

Description

CSM-Operator changes for CSM 1.11.1

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1478
dell/csm#1482

Checklist:

I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
I have verified that new and existing unit tests pass locally with my changes
I have not allowed coverage numbers to degenerate
I have maintained at least 90% code coverage
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

Installed csm-operator successfully
ran all unit tests
installed csi-unity, csi-powerstore and csi-powerflex using latest samples
ran cert-csi for all the installed drivers

…elease branch (#669) Signed-off-by: shefali-malhotra <kalrashefali10@gmail.com>

* Add Powerscale port variable * Template auth variables * Update go files * Add Powerscale port variable handling * Fix scenarios for PowerScale * Update powerscale template files

francis-nijay

There are multiple yaml lint errors that needs to be fixed

francis-nijay · 2024-09-26T06:01:21Z

We need to make sure all yams that has changes work without errors. Is e2e run successful?

* Fix pmaxCreds not set correctly in e2e * Update scenarios.yaml

ChristianAtDell · 2024-09-26T16:13:17Z

tests/e2e/testfiles/storage_csm_powerscale_resiliency.yaml

---
-apiVersion: v1
-kind: ConfigMap
-metadata:
-  name: isilon-config-params
-  namespace: isilon
-data:
-  driver-config-params.yaml: |
-    CSI_LOG_LEVEL: "debug"
-    CSI_LOG_FORMAT: "TEXT"
-    PODMON_CONTROLLER_LOG_LEVEL: "debug"
-    PODMON_CONTROLLER_LOG_FORMAT: "TEXT"
-    PODMON_NODE_LOG_LEVEL: "debug"
-    PODMON_NODE_LOG_FORMAT: "TEXT"
-spec:
-  driver:
-    configVersion: v2.11.0


Why are we removing this configmap? What did it do that was wrong? What does removing it unblock?

ChristianAtDell · 2024-09-26T16:16:36Z

tests/e2e/testfiles/storage_csm_powerscale_observability_top_custom_cert.yaml

@@ -1,488 +1,488 @@
-apiVersion: storage.dell.com/v1


What happened to this file, why is it being shown as every line removed and re-added? I can't see a difference between the two versions.

ChristianAtDell · 2024-09-26T16:19:05Z

tests/e2e/testfiles/storage_csm_powerscale_observability.yaml

@@ -1,488 +1,488 @@
-apiVersion: storage.dell.com/v1


This is another 500 line difference; what did this change encompass?

This PR is so large that it is crashing my browser trying to go through the diffs. If all of this is a result of YAML linting, then we should have rolled out those changes incrementally, shouldn't we?

JacobGros · 2024-09-26T16:34:53Z

bundle/manifests/dell-csm-operator.clusterserviceversion.yaml

  namespace: placeholder
 spec:
  apiservicedefinitions: {}
  customresourcedefinitions:
    owned:
-    - description: ApexConnectivityClient is the Schema for the ApexConnectivityClient


For everything below line1469:
Why were these changes made? What was the yaml lint error? It looks like these sections were removed and added back w/ no changes

oh I see, the indentation went up a level

ChristianAtDell · 2024-09-26T16:50:00Z

tests/e2e/testfiles/powerscale-templates/powerscale-auth-secret-template.yaml

-    endpointPort: "REPLACE_PORT"
+    endpointPort: REPLACE_AUTH_PORT


Here we have it as REPLACE_AUTH_PORT with no quotation...

Thought quotations was causing issues but it doesn't. With or without quotes it works but it was last verified without.

ChristianAtDell · 2024-09-26T16:51:04Z

tests/e2e/testfiles/powerscale-templates/powerscale-secret-template.yaml

-    endpointPort: 8080
+    endpointPort: "REPLACE_PORT"


... and here we have it inside quotation marks. Does it matter that it's in quotes sometimes and not in quotes others?

It doesn't matter. Tested with and without, both approaches worked but it was last tested with quotes in this scenario.

JacobGros · 2024-09-26T16:58:35Z

bundle/metadata/annotations.yaml

@@ -15,4 +15,4 @@ annotations:
  operators.operatorframework.io.test.config.v1: tests/scorecard/

  # Annotations to specify supported OCP versions.
-  com.redhat.openshift.versions: v4.15-v4.16
+  com.redhat.openshift.versions: "v4.15"


Main branch has:

com.redhat.openshift.versions: "v4.16-v4.17"

operator 1.6.0 has
com.redhat.openshift.versions: v4.15-v4.16
Are we dropping 4.16 for the patch only? If this is due to yaml lint fix, we probably want to put the range in quotes rather than get rid of 4.16

csm-operator/bundle/metadata/annotations.yaml

Line 18 in 639762a

com.redhat.openshift.versions: "v4.16-v4.17"

JacobGros · 2024-09-26T21:23:02Z

Call was made today to not include yaml lint fixes in1.6.1,
Opened this PR: #709 but kept this branch the same in case we ever need to revisit

shefali-malhotra and others added 13 commits August 30, 2024 12:16

porting back the changes done for posting and certification back in r…

2f77ed6

…elease branch (#669) Signed-off-by: shefali-malhotra <kalrashefali10@gmail.com>

changes of patch 1.6.1

0773fbb

missing changes of patch 1.6.1

6f68f5e

added common changes of patch 1.6.1

2e9672b

added unity changes for patch 1.6.1

0468765

added pfx changes for patch 1.6.1

57fe3e5

Merge branch 'release-v1.6.1' into patch-1.6.1

0056804

fix gosec issues

aece62c

formatting fixes

8f88b95

yamllint fixes

d919c70

yamllint fixes

8591919

yamllint fixes

e783973

Update storage_csm_unity_v2111.yaml

7e96b33

rishabhatdell marked this pull request as ready for review September 25, 2024 10:33

rishabhatdell requested review from abhi16394, mbasha-dell, alikdell, bharathsreekanth, chimanjain, coulof, Deepak-Ghivari, gallacher, HarishH-DELL, JacobGros, jooseppi-luna, karthikk92, kumarkgosa, bandak2, mjsdell and nitesh3108 as code owners September 25, 2024 10:33

rishabhatdell requested review from Prabhu-Dell, rajendraindukuri, rajkumar-palani, shefali-malhotra, panigs7, tdawe, shaynafinocchiaro, atye, sharmilarama and shanmydell as code owners September 25, 2024 10:33

ChristianAtDell and others added 2 commits September 25, 2024 15:46

Added necessary YAML and added scenario flags (#704)

44e03f1

Powerscale E2E Test Fixes (#705)

7d0ba03

* Add Powerscale port variable * Template auth variables * Update go files * Add Powerscale port variable handling * Fix scenarios for PowerScale * Update powerscale template files

nitesh3108 approved these changes Sep 26, 2024

View reviewed changes

HarishH-DELL approved these changes Sep 26, 2024

View reviewed changes

francis-nijay requested changes Sep 26, 2024

View reviewed changes

rishabhatdell and others added 3 commits September 26, 2024 12:23

Update storage_csm_powerflex_replica.yaml

39e15ab

fixed yaml lint errors

ca89db9

Fix pmaxCreds not set correctly in e2e (#706)

5029b0e

* Fix pmaxCreds not set correctly in e2e * Update scenarios.yaml

ChristianAtDell reviewed Sep 26, 2024

View reviewed changes

JacobGros reviewed Sep 26, 2024

View reviewed changes

ChristianAtDell reviewed Sep 26, 2024

View reviewed changes

JacobGros reviewed Sep 26, 2024

View reviewed changes

jooseppi-luna closed this Oct 1, 2024

mjsdell deleted the patch-1.6.1 branch October 17, 2024 19:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Patch 1.6.1 #699

Patch 1.6.1 #699

rishabhatdell commented Sep 24, 2024 •

edited

Loading

francis-nijay left a comment

francis-nijay commented Sep 26, 2024 •

edited

Loading

ChristianAtDell Sep 26, 2024

ChristianAtDell Sep 26, 2024

ChristianAtDell Sep 26, 2024

JacobGros Sep 26, 2024

JacobGros Sep 26, 2024

ChristianAtDell Sep 26, 2024

falfaroc Sep 26, 2024

ChristianAtDell Sep 26, 2024

falfaroc Sep 26, 2024

JacobGros Sep 26, 2024 •

edited

Loading

JacobGros commented Sep 26, 2024

Patch 1.6.1 #699

Patch 1.6.1 #699

Conversation

rishabhatdell commented Sep 24, 2024 • edited Loading

Description

GitHub Issues

Checklist:

How Has This Been Tested?

francis-nijay left a comment

Choose a reason for hiding this comment

francis-nijay commented Sep 26, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JacobGros Sep 26, 2024 • edited Loading

Choose a reason for hiding this comment

JacobGros commented Sep 26, 2024

rishabhatdell commented Sep 24, 2024 •

edited

Loading

francis-nijay commented Sep 26, 2024 •

edited

Loading

JacobGros Sep 26, 2024 •

edited

Loading