Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KRV-28472 - PowerFlex E2E Test Fixes #704

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

ChristianAtDell
Copy link
Contributor

Description

Minor changes made to resolve test failures and ensure tests are run when --pflex flag is passed in.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1478
dell/csm#1482

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

Run e2e test script has been run and passed with --pflex flag.

Copy link
Contributor

@JacobGros JacobGros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChristianAtDell ChristianAtDell merged commit 44e03f1 into patch-1.6.1 Sep 25, 2024
8 of 9 checks passed
@ChristianAtDell ChristianAtDell deleted the patch-1.6.1-pflex-fixes branch September 25, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants