Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting the manifest files #669

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

shefali-malhotra
Copy link
Contributor

@shefali-malhotra shefali-malhotra commented Aug 30, 2024

Updating the manifests and corrected auto generated code

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1221

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Operator posting is done with the following changes.

…elease branch

Signed-off-by: shefali-malhotra <kalrashefali10@gmail.com>
@chimanjain
Copy link
Contributor

Should these changes be present in the main branch also for next operator release

@shefali-malhotra
Copy link
Contributor Author

shefali-malhotra commented Aug 30, 2024

Should these changes be present in the main branch also for next operator release

yes I will be raising the separate PR for main branch

@shefali-malhotra shefali-malhotra merged commit 2f77ed6 into release-v1.6.0 Aug 30, 2024
7 of 9 checks passed
@shefali-malhotra shefali-malhotra deleted the final-release-manifest branch August 30, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants