complexity of build.ts #1539
Comments
github-merge-queue bot
pushed a commit
that referenced
this issue
Dec 11, 2024
## Description Build.ts ```bash 74:13 warning Async arrow function has too many statements (54). Maximum allowed is 20 max-statements 74:13 warning Async arrow function has a complexity of 18. Maximum allowed is 10 complexity 251:8 warning Async function 'buildModule' has too many statements (35). Maximum allowed is 20 max-statements ``` ## Related Issue Fixes #1539 <!-- or --> Relates to # ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Other (security config, docs update, etc) ## Checklist before merging - [x] Unit, [Journey](https://github.com/defenseunicorns/pepr/tree/main/journey), [E2E Tests](https://github.com/defenseunicorns/pepr-excellent-examples), [docs](https://github.com/defenseunicorns/pepr/tree/main/docs), [adr](https://github.com/defenseunicorns/pepr/tree/main/adr) added or updated as needed - [x] [Contributor Guide Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request) followed --------- Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com> Co-authored-by: Sam Mayer <sam.mayer@defenseunicorns.com>
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in Pepr Project Board
5 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Dec 16, 2024
## Description Collectively, the Pepr team has reviewed some large PRs lately (e.g., #1262, #1543, #1539, #1396, #1402, #1407). We prefer several smaller PRs to reduce the amount of time spent in code-review and to encourage working in small chunks. This script is an example of a pre-push hook using Husky that warns devs when their branch may be too large. This PR does not fulfill a need in the backlog, and does not _need_ to be merged. Rather, it's offered as an example to how a Pepr developer might use a similar script for their local development. ## Related Issue None. ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Other (security config, docs update, etc) ## Checklist before merging - [x] Unit, [Journey](https://github.com/defenseunicorns/pepr/tree/main/journey), [E2E Tests](https://github.com/defenseunicorns/pepr-excellent-examples), [docs](https://github.com/defenseunicorns/pepr/tree/main/docs), [adr](https://github.com/defenseunicorns/pepr/tree/main/adr) added or updated as needed - [x] [Contributor Guide Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request) followed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe what should be investigated or refactored
The text was updated successfully, but these errors were encountered: