chore(ts): add typing to adjudicators used in validation and mutation processing #1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
samayer12
force-pushed
the
1397-type-adjudicators
branch
from
029545e to
627f291
Compare
samayer12
force-pushed
the
1397-type-adjudicators
branch
from
627f291 to
a169536
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1402 +/- ##
==========================================
+ Coverage 79.12% 79.18% +0.05%
==========================================
Files 39 40 +1
Lines 1720 1734 +14
Branches 388 387 -1
==========================================
+ Hits 1361 1373 +12
- Misses 357 359 +2
Partials 2 2
|
samayer12
commented
Dec 4, 2024
samayer12
commented
Dec 4, 2024
samayer12
commented
Dec 4, 2024
samayer12
commented
Dec 4, 2024
src/lib/filter/adjudicators/bindingKubernetesObjectAdjudicators.test.ts
Outdated
Show resolved
Hide resolved
samayer12
commented
Dec 4, 2024
samayer12
commented
Dec 4, 2024
samayer12
commented
Dec 4, 2024
samayer12
commented
Dec 4, 2024
samayer12
commented
Dec 4, 2024
samayer12
commented
Dec 4, 2024
btlghrants
reviewed
Dec 4, 2024
btlghrants
approved these changes
Dec 4, 2024
cmwylie19
approved these changes
Dec 5, 2024
5 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 16, 2024
## Description Collectively, the Pepr team has reviewed some large PRs lately (e.g., #1262, #1543, #1539, #1396, #1402, #1407). We prefer several smaller PRs to reduce the amount of time spent in code-review and to encourage working in small chunks. This script is an example of a pre-push hook using Husky that warns devs when their branch may be too large. This PR does not fulfill a need in the backlog, and does not _need_ to be merged. Rather, it's offered as an example to how a Pepr developer might use a similar script for their local development. ## Related Issue None. ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Other (security config, docs update, etc) ## Checklist before merging - [x] Unit, [Journey](https://github.com/defenseunicorns/pepr/tree/main/journey), [E2E Tests](https://github.com/defenseunicorns/pepr-excellent-examples), [docs](https://github.com/defenseunicorns/pepr/tree/main/docs), [adr](https://github.com/defenseunicorns/pepr/tree/main/adr) added or updated as needed - [x] [Contributor Guide Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request) followed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The adjudicators are untyped, which caused complications when merging PR #1333. We should use TypeScript to enforce typing so that any refactors to filtering are based upon a solid foundation that does not require intermediate kludges with the typing system.
End to End Test:
(See Pepr Excellent Examples)
Related Issue
Relates to #1248, #1406, #1407, #1408, #1409, #1397
Type of change
Checklist before merging