Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: complexity in build #1557

Merged
merged 6 commits into from
Dec 11, 2024
Merged

chore: complexity in build #1557

merged 6 commits into from
Dec 11, 2024

Conversation

cmwylie19
Copy link
Collaborator

@cmwylie19 cmwylie19 commented Dec 10, 2024

Description

Build.ts

   74:13  warning  Async arrow function has too many statements (54). Maximum allowed is 20          max-statements
   74:13  warning  Async arrow function has a complexity of 18. Maximum allowed is 10                complexity
  251:8   warning  Async function 'buildModule' has too many statements (35). Maximum allowed is 20  max-statements

Related Issue

Fixes #1539

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
@cmwylie19 cmwylie19 requested a review from a team as a code owner December 10, 2024 20:38
@cmwylie19 cmwylie19 marked this pull request as draft December 10, 2024 20:39
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
@cmwylie19 cmwylie19 changed the title chore: WIP chore: complexity in build Dec 10, 2024
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 65.78947% with 26 lines in your changes missing coverage. Please review.

Project coverage is 78.29%. Comparing base (a7989f7) to head (a8ab588).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/cli/build.helpers.ts 65.78% 26 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1557      +/-   ##
==========================================
- Coverage   78.82%   78.29%   -0.53%     
==========================================
  Files          41       41              
  Lines        1804     1880      +76     
  Branches      403      417      +14     
==========================================
+ Hits         1422     1472      +50     
- Misses        380      406      +26     
  Partials        2        2              
Files with missing lines Coverage Δ
src/cli/build.helpers.ts 68.67% <65.78%> (-31.33%) ⬇️

Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
@cmwylie19 cmwylie19 marked this pull request as ready for review December 10, 2024 22:24
Copy link
Collaborator

@samayer12 samayer12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good first-step toward making key files to the Pepr workflow more modular and easier to test/change. Thanks!

@samayer12 samayer12 enabled auto-merge December 11, 2024 17:37
@samayer12 samayer12 added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit 0e50003 Dec 11, 2024
48 checks passed
@samayer12 samayer12 deleted the 1539 branch December 11, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

complexity of build.ts
2 participants