Repository navigation
Display numeric physical quantities with their units after the value - #1143
Merged
WaylandYang merged 2 commits intoOct 10, 2026
Merged
WaylandYang merged 2 commits into
WaylandYang merged 2 commits into
Conversation
Signed-off-by: Rudy Celekli <rudy@gradiahq.com>
WaylandYang
approved these changes
Oct 10, 2026
WaylandYang
left a comment
WaylandYang
left a comment
Contributor
There was a problem hiding this comment.
Thank you for this. Confirmed: an adopted numeric value with a non-currency unit was shown as MW500. Checked on top of dev together with the other fixes from this batch that we are taking: typecheck clean, web tests and the affected crate tests pass. Thanks again.
This was referenced Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopted physical quantities display as kg42 or MW42 because every unit is treated as a currency prefix. Keep currency symbols in front and physical units after the number.
Validation: focused regression fails on baseline and passes fixed; related suites where present, frontend typecheck, style guard and production build pass. No backend or database tests were run.