Skip to content

Keep citation identifiers decimal and exactly representable - #1144

Closed
rudycelekli wants to merge 1 commit into
deeplethe:devfrom
rudycelekli:fix/citation-canonical-positive-identifiers-20261009
Closed

rudycelekli wants to merge 1 commit into
deeplethe:devfrom
rudycelekli:fix/citation-canonical-positive-identifiers-20261009

Conversation

@rudycelekli

Copy link
Copy Markdown
Contributor

Hexadecimal, exponent and unsafe integer citation identifiers are converted into unrelated source numbers. Accept positive safe decimal identifiers consistently in text and citation links.

Validation: focused regression fails on baseline and passes fixed; related suites where present, frontend typecheck, style guard and production build pass. No backend or database tests were run.

Signed-off-by: Rudy Celekli <rudy@gradiahq.com>
@WaylandYang

Copy link
Copy Markdown
Contributor

Thank you for going through the codebase this carefully. We are taking eight from this batch (#1140, #1143, #1147, #1148, #1157, #1163, #1166, #1168), each a behaviour someone using Utopia would hit.

We are closing this one: it guards against an input we have not seen in use, and we keep the code and its tests to what the product needs today.

If you see this happen in a real deployment, please open an issue with the case and we will take it. For future sweeps, one issue listing the findings first would let us pick together before you write the fixes.

Thanks again for the time you put into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants