Repository navigation
Reject malformed transcription time anchors - #1152
Closed
rudycelekli wants to merge 1 commit into
Closed
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
Signed-off-by: Rudy Celekli <rudy@gradiahq.com>
Contributor
|
Thank you for going through the codebase this carefully. We are taking eight from this batch (#1140, #1143, #1147, #1148, #1157, #1163, #1166, #1168), each a behaviour someone using Utopia would hit. We are closing this one: it guards against an input we have not seen in use, and we keep the code and its tests to what the product needs today. If you see this happen in a real deployment, please open an issue with the case and we will take it. For future sweeps, one issue listing the findings first would let us pick together before you write the fixes. Thanks again for the time you put into this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing, negative, inverted or out-of-range transcript timestamps silently become zero or saturated millisecond anchors. Reject malformed nonempty segments rather than attaching plausible but incorrect audio provenance.
Validation: malformed timestamps fail baseline regression and are rejected with the fix; valid fractional-second anchors remain exact. All 24 bounded ingestion tests pass, compiling the actual block, chunker, provenance, reading and transcript modules with their real dependencies. rustfmt passes. Full workspace, live transcription service and database tests were not run.