Skip to content

Reject malformed transcription time anchors - #1152

Closed
rudycelekli wants to merge 1 commit into
deeplethe:devfrom
rudycelekli:fix/transcription-valid-time-anchors-20261009
Closed

rudycelekli wants to merge 1 commit into
deeplethe:devfrom
rudycelekli:fix/transcription-valid-time-anchors-20261009

Conversation

@rudycelekli

Copy link
Copy Markdown
Contributor

Missing, negative, inverted or out-of-range transcript timestamps silently become zero or saturated millisecond anchors. Reject malformed nonempty segments rather than attaching plausible but incorrect audio provenance.

Validation: malformed timestamps fail baseline regression and are rejected with the fix; valid fractional-second anchors remain exact. All 24 bounded ingestion tests pass, compiling the actual block, chunker, provenance, reading and transcript modules with their real dependencies. rustfmt passes. Full workspace, live transcription service and database tests were not run.

Signed-off-by: Rudy Celekli <rudy@gradiahq.com>
@WaylandYang

Copy link
Copy Markdown
Contributor

Thank you for going through the codebase this carefully. We are taking eight from this batch (#1140, #1143, #1147, #1148, #1157, #1163, #1166, #1168), each a behaviour someone using Utopia would hit.

We are closing this one: it guards against an input we have not seen in use, and we keep the code and its tests to what the product needs today.

If you see this happen in a real deployment, please open an issue with the case and we will take it. For future sweeps, one issue listing the findings first would let us pick together before you write the fixes.

Thanks again for the time you put into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants