Skip to content

137 reorganise images #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Feb 9, 2022
Merged

137 reorganise images #182

merged 26 commits into from
Feb 9, 2022

Conversation

tobyhodges
Copy link
Member

@tobyhodges tobyhodges commented Feb 7, 2022

Fixes #137
Fixes #173
Fixes #83 (thank you to @mmeysenburg for sharing the file with me by email!)
Fixes #84

Replaces #153 because the merge conflicts were getting chaotic.

A couple things that need discussing:

  1. This PR will delete a lot of image files that do not seem to be used in the lesson anymore. It also removes all the image files in the subfolders of code/, because It believe the duplication is now unnecessary. I want to highlight:
    a. the removal of code/05-creating-histograms/plate-01.tif because we seem to be using the JPEG in the challenge now instead?
    b. the removal of code/09-challenges/colonies*.tif because again we seem to be using the JPEGs throughout the lesson now?
  2. I chose the fig/07-junk.jpg file as the main "junk" image to use in data - it does not have the black outline around it, so seems like the best source image to use in processing during the lesson?

@uschille
Copy link
Contributor

uschille commented Feb 8, 2022

Thanks for all the work on this one @tobyhodges. I browsed through the episodes and everything looked fine.

One suggestion I'd have is to perhaps rename the junk- image files to shapes- or something like that.

@tobyhodges
Copy link
Member Author

Good suggestion thanks @uschille. Taken care of in adbc4a5

Copy link
Contributor

@uschille uschille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @tobyhodges. I have updated the Markdown files for the episodes and I think all looks good.

@K-Meech
Copy link
Contributor

K-Meech commented Feb 8, 2022

@tobyhodges Using the jpgs for the histograms and challenges episodes is due to my changes. I actually hadn't realised the tifs existed! I'll take a look at this. If the tifs are higher resolution, then we should probably use those instead...

@K-Meech
Copy link
Contributor

K-Meech commented Feb 8, 2022

@tobyhodges I just checked - and the tif and jpg versions seem to be identical in size/content. As jpg uses lossy compression though, I think it'd be better to keep the tif versions and remove the jpg. In the long run, we could also save these as png instead to make them more consistent with the rest of the images in the lesson.

@tobyhodges
Copy link
Member Author

Thanks @uschille for finishing the renaming task.

@tobyhodges
Copy link
Member Author

@K-Meech with the last few commits I restored the TIFF versions of wellplate-02 and the colonies- files - please could you glance over those quickly in case I missed something? Then, I think this one is good to go 🤞

Copy link
Contributor

@quist00 quist00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on my local build.

@tobyhodges tobyhodges merged commit 86a5a87 into gh-pages Feb 9, 2022
@tobyhodges tobyhodges deleted the 137-reorganise-images branch February 9, 2022 06:39
@tobyhodges tobyhodges mentioned this pull request Aug 16, 2022
zkamvar pushed a commit that referenced this pull request Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants