-
-
Notifications
You must be signed in to change notification settings - Fork 125
137 reorganise images #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for all the work on this one @tobyhodges. I browsed through the episodes and everything looked fine. One suggestion I'd have is to perhaps rename the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @tobyhodges. I have updated the Markdown files for the episodes and I think all looks good.
@tobyhodges Using the jpgs for the histograms and challenges episodes is due to my changes. I actually hadn't realised the tifs existed! I'll take a look at this. If the tifs are higher resolution, then we should probably use those instead... |
@tobyhodges I just checked - and the tif and jpg versions seem to be identical in size/content. As jpg uses lossy compression though, I think it'd be better to keep the tif versions and remove the jpg. In the long run, we could also save these as png instead to make them more consistent with the rest of the images in the lesson. |
Thanks @uschille for finishing the renaming task. |
@K-Meech with the last few commits I restored the TIFF versions of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on my local build.
Fixes #137
Fixes #173
Fixes #83 (thank you to @mmeysenburg for sharing the file with me by email!)
Fixes #84
Replaces #153 because the merge conflicts were getting chaotic.
A couple things that need discussing:
code/
, because It believe the duplication is now unnecessary. I want to highlight:a. the removal of
code/05-creating-histograms/plate-01.tif
because we seem to be using the JPEG in the challenge now instead?b. the removal of
code/09-challenges/colonies*.tif
because again we seem to be using the JPEGs throughout the lesson now?fig/07-junk.jpg
file as the main "junk" image to use indata
- it does not have the black outline around it, so seems like the best source image to use in processing during the lesson?