Skip to content

fix: transient table no work as expected inside explicit transaction #18160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 17, 2025
Merged

fix: transient table no work as expected inside explicit transaction #18160

merged 9 commits into from
Jun 17, 2025

Conversation

@dantengsky
Copy link
Member

@dantengsky dantengsky commented Jun 13, 2025 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Instead of caching table meta timestamps in txn manager, build table
meta timestamps according to the last visible table state inside the
transaction.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Jun 13, 2025
@dantengsky dantengsky force-pushed the fix-transient-table-within-explicit-txn branch 2 times, most recently from 3969673 to ad4b242 Compare June 13, 2025 17:36
@dantengsky dantengsky changed the title fix: Add small timestamp buffer for transient tables in explicit transactions fix: transient table no work as expected inside explicit transaction Jun 13, 2025
@dantengsky dantengsky force-pushed the fix-transient-table-within-explicit-txn branch 2 times, most recently from 46800ef to f35a68b Compare June 13, 2025 18:38
@dantengsky
fix: transient table not work as expected inside explicit txn
fbec09a 
Instead of caching table meta timestamps in txn manager, build table
meta timestamps according to the last visible table state inside the
transaction.
@dantengsky dantengsky force-pushed the fix-transient-table-within-explicit-txn branch from f35a68b to fbec09a Compare June 14, 2025 03:45
@dantengsky dantengsky added the ci-cloud Build docker image for cloud test label Jun 14, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 14, 2025

Docker Image for PR

  • tag: pr-18160-4c38b21-1749898285

note: this image tag is only available for internal use.

@dantengsky dantengsky force-pushed the fix-transient-table-within-explicit-txn branch from 04e0361 to b1d682f Compare June 14, 2025 12:02
@dantengsky dantengsky marked this pull request as ready for review June 17, 2025 01:42
@dantengsky dantengsky requested a review from SkyFan2002 June 17, 2025 01:42
@dantengsky
Copy link
Member Author

dantengsky commented Jun 17, 2025

Passed smoking tests

@SkyFan2002 SkyFan2002 self-requested a review June 17, 2025 03:01
@BohuTANG BohuTANG merged commit 461a1e4 into databendlabs:main Jun 17, 2025
78 checks passed
@dantengsky
Copy link
Member Author

dantengsky commented Jun 17, 2025

REVERTING, THIS PR MAY NOT SAFE

dantengsky added a commit to dantengsky/fuse-query that referenced this pull request Jun 17, 2025
@dantengsky
Revert "fix: transient table no work as expected inside explicit tran…
9e6e10b 
…saction (databendlabs#18160)"

This reverts commit 461a1e4.
@dantengsky dantengsky mentioned this pull request Jun 17, 2025
Merged
11 tasks
BohuTANG pushed a commit that referenced this pull request Jun 17, 2025
@dantengsky
chore: revert "fix: transient table no work as expected inside explic…
b0c1c1e 
…it transaction (#18160) (#18172)

Revert "fix: transient table no work as expected inside explicit transaction (#18160)"

This reverts commit 461a1e4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SkyFan2002 SkyFan2002 Awaiting requested review from SkyFan2002

Assignees

No one assigned

Labels

ci-cloud Build docker image for cloud test pr-bugfix this PR patches a bug in codebase

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: auto-compaction of transient tables fails silently bug: transient table no work as expected inside explicit transaction

3 participants

@dantengsky @SkyFan2002 @BohuTANG