fix: transient table not work as expected inside explicit txn

Instead of caching table meta timestamps in txn manager, build table
meta tiemstamp according to the last visible table inside the
transation.

Author: dantengsky

src/query/storages/common/session/src/transaction.rs

@@ -12,7 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-use std::collections::hash_map::Entry;
 use std::collections::BTreeMap;
 use std::collections::HashMap;
 use std::collections::HashSet;
@@ -66,8 +65,7 @@ pub struct TxnBuffer {
     stream_tables: HashMap<u64, StreamSnapshot>,
     need_purge_files: Vec<(StageInfo, Vec<String>)>,
 
-    pub table_meta_timestamps: HashMap<u64, TableMetaTimestamps>,
-
+    // pub table_meta_timestamps: HashMap<u64, TableMetaTimestamps>,
     temp_table_desc_to_id: HashMap<String, u64>,
     mutated_temp_tables: HashMap<u64, TempTable>,
 }
@@ -366,23 +364,25 @@ impl TxnManager {
 
     pub fn get_table_meta_timestamps(
         &mut self,
-        table_id: u64,
+        _table_id: u64,
         previous_snapshot: Option<Arc<TableSnapshot>>,
         delta: Duration,
     ) -> TableMetaTimestamps {
         if !self.is_active() {
             return TableMetaTimestamps::new(previous_snapshot, delta);
         }
 
-        let entry = self.txn_buffer.table_meta_timestamps.entry(table_id);
-        match entry {
-            Entry::Occupied(e) => *e.get(),
-            Entry::Vacant(e) => {
-                let timestamps = TableMetaTimestamps::new(previous_snapshot, delta);
-                e.insert(timestamps);
-                timestamps
-            }
-        }
+        TableMetaTimestamps::new(previous_snapshot, delta)
+
+        // let entry = self.txn_buffer.table_meta_timestamps.entry(table_id);
+        // match entry {
+        //    Entry::Occupied(e) => *e.get(),
+        //    Entry::Vacant(e) => {
+        //        let timestamps = TableMetaTimestamps::new(previous_snapshot, delta);
+        //        e.insert(timestamps);
+        //        timestamps
+        //    }
+        //}
     }
 
     pub fn get_base_snapshot_location(&self, table_id: u64) -> Option<String> {

tests/sqllogictests/suites/base/issues/issue_18160.test

@@ -0,0 +1,35 @@
+statement ok
+create or replace database issue_18159
+
+statement ok
+use issue_18159
+
+statement ok
+create or replace transient table c( c int);
+
+statement ok
+insert into c values(1);
+
+statement ok
+begin;
+
+statement ok
+delete from c where c = 1;
+
+statement ok
+insert into c values(2);
+
+statement ok
+insert into c values(3);
+
+statement ok
+commit;
+
+query T
+select * from c order by c;
+----
+2
+3
+
+statement ok
+drop database issue_18159