Skip to content

chore: revert "fix: transient table no work as expected inside explicit transaction (#18160) #18172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2025
Merged

chore: revert "fix: transient table no work as expected inside explicit transaction (#18160) #18172

merged 1 commit into from
Jun 17, 2025

Conversation

@dantengsky
Copy link
Member

@dantengsky dantengsky commented Jun 17, 2025 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

This reverts PR #18160, which need to be reviewed further.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - revert

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe): revert

This change is Reviewable

@dantengsky dantengsky changed the title Revert "fix: transient table no work as expected inside explicit transaction (#18160) chore: Revert "fix: transient table no work as expected inside explicit transaction (#18160) Jun 17, 2025
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Jun 17, 2025
@dantengsky dantengsky changed the title chore: Revert "fix: transient table no work as expected inside explicit transaction (#18160) chore: revert "fix: transient table no work as expected inside explicit transaction (#18160) Jun 17, 2025
@dantengsky dantengsky marked this pull request as ready for review June 17, 2025 04:54
@dantengsky dantengsky requested a review from SkyFan2002 June 17, 2025 04:54
@BohuTANG BohuTANG merged commit b0c1c1e into databendlabs:main Jun 17, 2025
91 of 93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SkyFan2002 SkyFan2002 SkyFan2002 approved these changes

Assignees

No one assigned

Labels

pr-chore this PR only has small changes that no need to record, like coding styles.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dantengsky @SkyFan2002 @BohuTANG