chore: update to 2.0.0 rc-1 #2557
Conversation
WalkthroughThis change updates the version numbers for numerous packages across the repository from a development pre-release (e.g., Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Dashmate
participant MigrationEngine
User->>Dashmate: Start/Upgrade to 2.0.0-rc.1
Dashmate->>MigrationEngine: Apply migrations for 2.0.0-rc.1
MigrationEngine->>MigrationEngine: Remove core.miner.mediantime, set Docker images to rc tags
MigrationEngine-->>Dashmate: Return updated configFile
Dashmate-->>User: Migration complete
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (47)
package.json(1 hunks)packages/bench-suite/package.json(1 hunks)packages/check-features/Cargo.toml(1 hunks)packages/dapi-grpc/Cargo.toml(1 hunks)packages/dapi-grpc/package.json(1 hunks)packages/dapi/package.json(1 hunks)packages/dashmate/configs/getConfigFileMigrationsFactory.js(1 hunks)packages/dashmate/package.json(1 hunks)packages/dashpay-contract/Cargo.toml(1 hunks)packages/dashpay-contract/package.json(1 hunks)packages/data-contracts/Cargo.toml(1 hunks)packages/dpns-contract/Cargo.toml(1 hunks)packages/dpns-contract/package.json(1 hunks)packages/feature-flags-contract/Cargo.toml(1 hunks)packages/feature-flags-contract/package.json(1 hunks)packages/js-dapi-client/package.json(1 hunks)packages/js-dash-sdk/package.json(1 hunks)packages/js-grpc-common/package.json(1 hunks)packages/keyword-search-contract/Cargo.toml(1 hunks)packages/masternode-reward-shares-contract/Cargo.toml(1 hunks)packages/masternode-reward-shares-contract/package.json(1 hunks)packages/platform-test-suite/package.json(1 hunks)packages/rs-dapi-client/Cargo.toml(1 hunks)packages/rs-dapi-grpc-macros/Cargo.toml(1 hunks)packages/rs-dpp/Cargo.toml(1 hunks)packages/rs-drive-abci/Cargo.toml(1 hunks)packages/rs-drive-proof-verifier/Cargo.toml(1 hunks)packages/rs-drive/Cargo.toml(1 hunks)packages/rs-json-schema-compatibility-validator/Cargo.toml(1 hunks)packages/rs-platform-serialization-derive/Cargo.toml(1 hunks)packages/rs-platform-serialization/Cargo.toml(1 hunks)packages/rs-platform-value-convertible/Cargo.toml(1 hunks)packages/rs-platform-value/Cargo.toml(1 hunks)packages/rs-platform-version/Cargo.toml(1 hunks)packages/rs-platform-versioning/Cargo.toml(1 hunks)packages/rs-sdk/Cargo.toml(1 hunks)packages/simple-signer/Cargo.toml(1 hunks)packages/strategy-tests/Cargo.toml(1 hunks)packages/token-history-contract/Cargo.toml(1 hunks)packages/token-history-contract/package.json(1 hunks)packages/wallet-lib/package.json(1 hunks)packages/wallet-utils-contract/Cargo.toml(1 hunks)packages/wallet-utils-contract/package.json(1 hunks)packages/wasm-dpp/Cargo.toml(1 hunks)packages/wasm-dpp/package.json(1 hunks)packages/withdrawals-contract/Cargo.toml(1 hunks)packages/withdrawals-contract/package.json(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: QuantumExplorer
PR: dashpay/platform#2257
File: packages/rs-drive-abci/src/mimic/test_quorum.rs:159-164
Timestamp: 2024-11-20T16:16:01.830Z
Learning: QuantumExplorer prefers not to receive auto-generated messages asking to post on social media.
🪛 Biome (1.9.4)
packages/dashmate/configs/getConfigFileMigrationsFactory.js
[error] 1082-1082: Avoid the delete operator which can impact performance.
Unsafe fix: Use an undefined assignment instead.
(lint/performance/noDelete)
🔇 Additional comments (46)
packages/rs-dpp/Cargo.toml (1)
3-3: Version bump to release candidate
The package version has been correctly updated from the pre‑release2.0.0-dev.1to2.0.0-rc.1, aligning with the coordinated rc‑1 rollout across the repository.packages/rs-platform-version/Cargo.toml (1)
5-5:✅ Verification successful
Bump crate version to release candidate
Theversionfield has been updated to2.0.0-rc.1as expected for the release candidate.
Please verify that all other related Rust crates and JavaScript packages have also been bumped from2.0.0-dev.1to2.0.0-rc.1for consistency across the repo.Run this script to confirm no lingering
-dev.1references remain:
🏁 Script executed:
#!/usr/bin/env bash # Verify that no '2.0.0-dev.1' occurrences are left in the repository rg -F '"2.0.0-dev.1"' -n .Length of output: 28
No lingering 2.0.0‑dev.1 references found
I ranrg -F '"2.0.0-dev.1"' -n .against the repo and confirmed there are no remaining occurrences. All Rust crates and JavaScript packages are correctly bumped to2.0.0-rc.1.packages/rs-platform-serialization-derive/Cargo.toml (1)
5-5:✅ Verification successful
Confirm version bump to release candidate.
The package version has been updated to
2.0.0-rc.1, aligning with the planned RC release. Ensure this change is in sync across all related crates to avoid version mismatches.To verify there are no remaining pre-release versions, run:
🏁 Script executed:
#!/bin/bash # Search for any lingering `2.0.0-dev.1` entries in Cargo.toml files rg -l 'version = "2.0.0-dev.1"' --glob '*.toml'Length of output: 49
Version bump to 2.0.0-rc.1 confirmed
- packages/rs-platform-serialization-derive/Cargo.toml has been updated to
2.0.0-rc.1- Search across all Cargo.toml files found no lingering
version = "2.0.0-dev.1"entriesAll crates are in sync and ready for the RC release.
packages/data-contracts/Cargo.toml (1)
4-4:✅ Verification successful
Bump version to release candidate
The crate’s version has been updated from2.0.0-dev.1to2.0.0-rc.1in preparation for the RC build.Run this script to confirm no lingering pre-release references remain in the workspace:
🏁 Script executed:
#!/bin/bash # Ensure all Cargo.toml files have been updated from `2.0.0-dev.1` to `2.0.0-rc.1`. rg -n '"2.0.0-dev.1"'Length of output: 23
No lingering pre-release references found – approving version bump
Verified thatrg -n '"2.0.0-dev.1"'returns no matches, so all Cargo.toml files now reference2.0.0-rc.1. Version bump is complete.packages/token-history-contract/Cargo.toml (1)
4-4:✅ Verification successful
Release Candidate Version Bump
The package version has been correctly updated from
2.0.0-dev.1to2.0.0-rc.1. Please confirm that there are no remaining references to the development pre-release version elsewhere in the workspace to ensure consistency.Run this script from the repository root to verify no leftover
2.0.0-dev.1strings remain:Expected result: zero matches.
🏁 Script executed:
#!/bin/bash # Verify no remaining dev-version references rg -n 'version = "2.0.0-dev.1"'Length of output: 33
No leftover
2.0.0-dev.1references detectedI ran the suggested ripgrep check across the workspace and confirmed there are zero matches for
version = "2.0.0-dev.1". The version bump to2.0.0-rc.1is consistent throughout the codebase.packages/rs-platform-serialization/Cargo.toml (1)
5-5:✅ Verification successful
Release candidate version bump
Crate version updated from2.0.0-dev.1to2.0.0-rc.1. Ensure this aligns with other workspace crates and the publishing pipeline for RC releases.Please run the following to catch any remaining dev versions:
🏁 Script executed:
#!/bin/bash # Verify no leftover development versions in Cargo.toml rg -n 'version = "2.0.0-dev.1"'Length of output: 33
🏁 Script executed:
#!/bin/bash # Verify no leftover development version strings in any Cargo.toml across the workspace rg -n 'version\s*=\s*".*-dev' --glob 'Cargo.toml'Length of output: 49
Release Candidate Version Bump Approved
All
Cargo.tomlfiles have been checked for any remaining-devversion strings and none were found. The crate version is now consistently set to2.0.0-rc.1across the workspace.• Snippet in
packages/rs-platform-serialization/Cargo.toml:- version = "2.0.0-dev.1" + version = "2.0.0-rc.1"Feel free to proceed with the RC publish.
packages/rs-drive/Cargo.toml (2)
4-4: Approve version bump to rc-1
The package version has been correctly updated from2.0.0-dev.1to2.0.0-rc.1, aligning with the coordinated release candidate across the repository.
4-4:✅ Verification successful
Verify no residual dev pre-release versions
To ensure consistency, please search for any remaining2.0.0-dev.1references in other Cargo.toml files.
🏁 Script executed:
#!/bin/bash # Description: Find any Cargo.toml still referencing the old dev pre-release version. rg -n '"2.0.0-dev.1"' -- '*.toml'Length of output: 82
🏁 Script executed:
#!/bin/bash # Description: Correctly search all Cargo.toml files for any remaining ‘2.0.0-dev.1’ references rg -n '2\.0\.0-dev\.1' -g 'Cargo.toml'Length of output: 38
No residual
2.0.0-dev.1references found
AllCargo.tomlfiles have been updated to2.0.0-rc.1and no occurrences of2.0.0-dev.1remain.packages/rs-platform-value-convertible/Cargo.toml (1)
5-5:❓ Verification inconclusive
Approve bump from dev to rc candidate
The version field has been correctly updated from the development pre‑release to the release‑candidate2.0.0-rc.1.
Please verify that all other workspaceCargo.tomlfiles and any inter‑crate dependencies have been similarly updated to avoid version mismatches.To confirm no lingering
dev.1references remain, you can run:
🏁 Script executed:
#!/bin/bash # Verify no remaining '2.0.0-dev.1' references in Cargo.toml manifests rg '"2\.0\.0-dev\.1"' -g "Cargo.toml"Length of output: 37
🏁 Script executed:
#!/bin/bash # 1. Check for any lingering '2.0.0-dev.1' references across all TOML files rg -n '2\.0\.0-dev\.1' -g '*.toml' # 2. List all version fields in every Cargo.toml to confirm they’re set to 2.0.0-rc.1 rg -n '^version\s*=' -g 'Cargo.toml'Length of output: 1940
Confirm version bump across workspace
No lingering2.0.0-dev.1references were found, and all workspace crates have theirversionset to2.0.0-rc.1except:
packages/rs-drive-verify-c-binding/Cargo.tomlremains at1.6.2(external C‑binding)Please verify that the C‑binding crate’s version should intentionally differ.
packages/token-history-contract/package.json (1)
3-3: Approve the release candidate version bump.The
versionfield is updated from2.0.0-dev.1to2.0.0-rc.1, consistent with the broader RC-1 rollout.packages/rs-sdk/Cargo.toml (1)
3-3: Approve the release candidate version bump.The
dash-sdkcrate’sversionhas been bumped to2.0.0-rc.1as part of the coordinated RC update.packages/rs-drive-abci/Cargo.toml (1)
3-3: Approve the release candidate version bump.The
drive-abcicrate’sversionhas been correctly updated to2.0.0-rc.1.packages/dashpay-contract/package.json (1)
3-3: Approve the release candidate version bump.The contract package’s
versionis now2.0.0-rc.1, in line with the other packages.packages/js-dash-sdk/package.json (1)
3-3: Release version bump to 5.0.0-rc.1
The version field has been correctly updated from the previous pre-release to therc-1tag, matching the release candidate labeling across the repository.packages/dapi/package.json (1)
4-4: Release version bump to 2.0.0-rc.1
The package version was updated from2.0.0-dev.1to2.0.0-rc.1, consistent with the coordinated release candidate roll‑out.packages/wallet-lib/package.json (1)
3-3: Release version bump to 9.0.0-rc.1
The version has been correctly updated to the RC tag, in line with the rest of the workspace packages.packages/dpns-contract/Cargo.toml (1)
4-4: Release version bump to 2.0.0-rc.1
TheCargo.tomlversion was updated from the dev pre-release to the RC-1 version, ensuring consistency across Rust contract crates.packages/rs-dapi-client/Cargo.toml (1)
3-3: Release version bump to 2.0.0-rc.1
The crate version has been bumped from2.0.0-dev.1to2.0.0-rc.1, in sync with the broader release candidate update.packages/simple-signer/Cargo.toml (1)
3-3: Consistent version bump to 2.0.0-rc.1
The package version has been updated from2.0.0-dev.1to2.0.0-rc.1, matching the coordinated release candidate across all crates. No functional changes detected.packages/bench-suite/package.json (1)
4-4: Updateversionfield to 2.0.0-rc.1
The@dashevo/bench-suitepackage version is now aligned with the new release candidate. Ensure any CI/CD pipelines or publishing scripts reference the updated version.packages/dashpay-contract/Cargo.toml (1)
4-4: Bump DashPay‑contract crate to rc‑1
Thedashpay-contractcrate version has been incremented to2.0.0-rc.1. This is consistent with the release candidate tagging; no other changes were introduced.packages/rs-platform-value/Cargo.toml (1)
5-5: Alignplatform-valuecrate version with RC
Updated the version to2.0.0-rc.1as part of the RC‐1 rollout. Confirm that any downstream consumers or workspace members pick up this new version.packages/check-features/Cargo.toml (1)
3-3: Version update forcheck-featuresto rc‑1
The manifest now reflects2.0.0-rc.1. This matches the broader version synchronization for the release candidate.packages/platform-test-suite/package.json (1)
4-4: Confirmed version bump to RC release candidate.The
versionfield has been updated from2.0.0-dev.1to2.0.0-rc.1, aligning this package with the overall release candidate update.packages/wallet-utils-contract/Cargo.toml (1)
4-4: Consistent Cargo version update.The Rust crate version was correctly bumped to
2.0.0-rc.1, matching the coordinated RC release across other contracts.packages/wasm-dpp/package.json (1)
3-3: JavaScript package version aligned to RC.The
@dashevo/wasm-dpppackage version has been updated to2.0.0-rc.1in line with the repository-wide bump.packages/js-dapi-client/package.json (1)
3-3: DAPI client version bump approved.The version field is now
2.0.0-rc.1, consistent with the PR goal of moving to the release candidate.packages/feature-flags-contract/Cargo.toml (1)
4-4: Feature-flags contract version updated.The
feature-flags-contractcrate version is correctly set to2.0.0-rc.1, matching the rest of the version bumps.packages/keyword-search-contract/Cargo.toml (1)
4-4: Version bump to release candidate
The version has been correctly updated from"2.0.0-dev.1"to"2.0.0-rc.1", aligning with the coordinated release candidate strategy across packages.packages/rs-drive-proof-verifier/Cargo.toml (1)
3-3: Version bump to release candidate
Updating the crate version to"2.0.0-rc.1"is consistent with the overall RC rollout. No other metadata changes detected.packages/feature-flags-contract/package.json (1)
3-3: Version bump to release candidate
Theversionfield has been updated to"2.0.0-rc.1"as expected for the RC release. All related scripts and metadata remain unchanged.packages/strategy-tests/Cargo.toml (1)
3-3: Version bump to release candidate
Crate version updated to"2.0.0-rc.1", matching the release candidate versioning scheme used repository-wide.packages/rs-json-schema-compatibility-validator/Cargo.toml (1)
3-3: Version bump to release candidate
The version has been updated to"2.0.0-rc.1", in line with the release candidate preparation. Dependencies and features are unchanged.packages/rs-dapi-grpc-macros/Cargo.toml (1)
4-4: Bump package version to 2.0.0-rc.1
Aligned with the coordinated version update across the mono-repo for the 2.0.0 release candidate.packages/withdrawals-contract/Cargo.toml (1)
4-4: Update version to 2.0.0-rc.1
Consistent release candidate version bump matching other contracts in the repository.packages/masternode-reward-shares-contract/Cargo.toml (1)
4-4: Upgrade crate version to 2.0.0-rc.1
This aligns the masternode‑reward‑shares contract with the RC‑1 release candidate.package.json (1)
3-3:✅ Verification successful
Set @dashevo/platform version to 2.0.0-rc.1
Matches the release candidate bump across all JS and Rust packages.Please verify that the corresponding migration entry for
2.0.0-rc.1has been added topackages/dashmate/configs/getConfigFileMigrationsFactory.js. You can run:
🏁 Script executed:
#!/bin/bash # Verify that the RC‑1 migration key is defined rg -C3 'rc.1' packages/dashmate/configs/getConfigFileMigrationsFactory.jsLength of output: 993
Migration entry for 2.0.0‑rc.1 is defined
Confirmed that the'2.0.0-rc.1'key exists in the migration map.• File: packages/dashmate/configs/getConfigFileMigrationsFactory.js
• Contains:
'2.0.0-rc.1': (configFile) => { Object.entries(configFile.configs) .forEach(([, options]) => { delete options.core.miner.mediantime;packages/rs-platform-versioning/Cargo.toml (1)
5-5: Bump version to 2.0.0-rc.1
Consistent with the repository-wide transition from dev to rc for 2.0.0.packages/dpns-contract/package.json (1)
3-3: Approve version update for DPNS contract
Bumped version to"2.0.0-rc.1"consistently with other packages. No other metadata was changed—looks good.packages/withdrawals-contract/package.json (1)
3-3: Approve version bump for withdrawals contract
Upgraded version to"2.0.0-rc.1"to sync with the RC release cycle. Confirm that CI and downstream consumers recognize this new tag.packages/wasm-dpp/Cargo.toml (1)
3-3:✅ Verification successful
Ensure crate version aligns with RC release
The crate version was updated to2.0.0-rc.1. This matches the coordinated bump across Rust and JS packages. Make sure the corresponding migration indashmate/configs/getConfigFileMigrationsFactory.jsis registered for2.0.0-rc.1.
🏁 Script executed:
#!/bin/bash # Check that rc-1 migration entry exists rg -n "rc\\.1" -A3 packages/dashmate/configs/getConfigFileMigrationsFactory.jsLength of output: 880
Migration Verified for 2.0.0‑rc.1
The entry for2.0.0-rc.1is present inpackages/dashmate/configs/getConfigFileMigrationsFactory.js(lines 1079–1082). Crate and JS package versions are aligned.packages/js-grpc-common/package.json (1)
3-3: Approve gRPC‐common package version bump
Version updated to"2.0.0-rc.1"as part of the RC-1 rollout. Ensure coverage thresholds still pass under this version.packages/dapi-grpc/Cargo.toml (1)
4-4: Version updated to rc.1The version has been correctly updated from development pre-release ("2.0.0-dev.1") to release candidate ("2.0.0-rc.1").
packages/dashmate/package.json (1)
3-3: Version updated to rc.1The version has been correctly updated from development pre-release ("2.0.0-dev.1") to release candidate ("2.0.0-rc.1").
packages/dapi-grpc/package.json (1)
3-3: Version updated to rc.1The version has been correctly updated from development pre-release ("2.0.0-dev.1") to release candidate ("2.0.0-rc.1").
packages/dashmate/configs/getConfigFileMigrationsFactory.js (1)
1079-1088: New migration added for rc.1A new migration function has been added for version '2.0.0-rc.1', which duplicates the existing migration for '2.0.0-dev.1'. This ensures that configurations are properly updated when upgrading to the release candidate version.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1082-1082: Avoid the delete operator which can impact performance.
Unsafe fix: Use an undefined assignment instead.
(lint/performance/noDelete)
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/dashmate/configs/getConfigFileMigrationsFactory.js (1)
1082-1082: Consider an alternative todeletefor better performance.The static analysis tool flagged the use of the
deleteoperator which can impact performance.- delete options.core.miner.mediantime; + options.core.miner.mediantime = undefined;🧰 Tools
🪛 Biome (1.9.4)
[error] 1082-1082: Avoid the delete operator which can impact performance.
Unsafe fix: Use an undefined assignment instead.
(lint/performance/noDelete)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/dashmate/configs/getConfigFileMigrationsFactory.js(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: QuantumExplorer
PR: dashpay/platform#2257
File: packages/rs-drive-abci/src/mimic/test_quorum.rs:159-164
Timestamp: 2024-11-20T16:16:01.830Z
Learning: QuantumExplorer prefers not to receive auto-generated messages asking to post on social media.
🪛 Biome (1.9.4)
packages/dashmate/configs/getConfigFileMigrationsFactory.js
[error] 1082-1082: Avoid the delete operator which can impact performance.
Unsafe fix: Use an undefined assignment instead.
(lint/performance/noDelete)
⏰ Context from checks skipped due to timeout of 90000ms (20)
- GitHub Check: Rust packages (withdrawals-contract) / Linting
- GitHub Check: Rust packages (dpns-contract) / Formatting
- GitHub Check: Rust packages (dpns-contract) / Tests
- GitHub Check: Rust packages (token-history-contract) / Unused dependencies
- GitHub Check: Rust packages (token-history-contract) / Formatting
- GitHub Check: Rust packages (token-history-contract) / Linting
- GitHub Check: Rust packages (token-history-contract) / Tests
- GitHub Check: Rust packages (dashpay-contract) / Tests
- GitHub Check: Rust packages (dashpay-contract) / Unused dependencies
- GitHub Check: Rust packages (dashpay-contract) / Formatting
- GitHub Check: Rust packages (dash-sdk) / Check each feature
- GitHub Check: Rust packages (dash-sdk) / Linting
- GitHub Check: Rust packages (dash-sdk) / Formatting
- GitHub Check: Rust packages (dapi-grpc) / Check each feature
- GitHub Check: Rust packages (dash-sdk) / Tests
- GitHub Check: Rust packages (dapi-grpc) / Tests
- GitHub Check: Rust packages (dapi-grpc) / Unused dependencies
- GitHub Check: Rust packages (dapi-grpc) / Linting
- GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
- GitHub Check: Build JS packages / Build JS
🔇 Additional comments (1)
packages/dashmate/configs/getConfigFileMigrationsFactory.js (1)
1079-1088: Migration function for RC version added correctly!The new migration function for
2.0.0-rc.1properly updates the Docker image tags from dev to release candidate versions while maintaining the functionality of deleting thecore.miner.mediantimeproperty. This change aligns with the PR objective of updating to the 2.0.0 RC-1 release.🧰 Tools
🪛 Biome (1.9.4)
[error] 1082-1082: Avoid the delete operator which can impact performance.
Unsafe fix: Use an undefined assignment instead.
(lint/performance/noDelete)
Issue being fixed or feature implemented
What was done?
How Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only
Summary by CodeRabbit