chore(platform): bump to version 2.0.0-dev.1 #2495
Conversation
WalkthroughThe changes update the version numbers of multiple packages from "1.8.0" (with a few exceptions) to "2.0.0-dev.1" (or similar dev versions) across both JavaScript and Rust package manifests. Additionally, one Rust file has an unused import removed, and one Cargo.toml updates its authors section. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Tip ⚡🧪 Multi-step agentic review comment chat (experimental)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
packages/rs-drive/Cargo.toml (1)
9-9:⚠️ Potential issueAuthor Email Format Issue
The email for "Wisdom Ogwu" is missing a closing angle bracket, which could lead to parsing errors. Please fix the formatting:
- "Wisdom Ogwu <wisdom@dash.org", + "Wisdom Ogwu <wisdom@dash.org>",
🧹 Nitpick comments (1)
packages/withdrawals-contract/Cargo.toml (1)
2-3: Typographical Correction in DescriptionThere is a minor typo in the description ("Witdrawals" should be "Withdrawals"). Consider updating it for clarity:
- description = "Witdrawals data contract schema and tools" + description = "Withdrawals data contract schema and tools"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (47)
package.json(1 hunks)packages/bench-suite/package.json(1 hunks)packages/check-features/Cargo.toml(1 hunks)packages/dapi-grpc/Cargo.toml(1 hunks)packages/dapi-grpc/package.json(1 hunks)packages/dapi/package.json(1 hunks)packages/dashmate/package.json(1 hunks)packages/dashpay-contract/Cargo.toml(1 hunks)packages/dashpay-contract/package.json(1 hunks)packages/data-contracts/Cargo.toml(1 hunks)packages/dpns-contract/Cargo.toml(1 hunks)packages/dpns-contract/package.json(1 hunks)packages/feature-flags-contract/Cargo.toml(1 hunks)packages/feature-flags-contract/package.json(1 hunks)packages/js-dapi-client/package.json(1 hunks)packages/js-dash-sdk/package.json(1 hunks)packages/js-grpc-common/package.json(1 hunks)packages/masternode-reward-shares-contract/Cargo.toml(1 hunks)packages/masternode-reward-shares-contract/package.json(1 hunks)packages/platform-test-suite/package.json(1 hunks)packages/rs-dapi-client/Cargo.toml(1 hunks)packages/rs-dapi-grpc-macros/Cargo.toml(1 hunks)packages/rs-dpp/Cargo.toml(1 hunks)packages/rs-dpp/src/data_contract/associated_token/token_perpetual_distribution/reward_distribution_type/evaluate_interval.rs(0 hunks)packages/rs-drive-abci/Cargo.toml(1 hunks)packages/rs-drive-proof-verifier/Cargo.toml(1 hunks)packages/rs-drive/Cargo.toml(1 hunks)packages/rs-json-schema-compatibility-validator/Cargo.toml(1 hunks)packages/rs-platform-serialization-derive/Cargo.toml(1 hunks)packages/rs-platform-serialization/Cargo.toml(1 hunks)packages/rs-platform-value-convertible/Cargo.toml(1 hunks)packages/rs-platform-value/Cargo.toml(1 hunks)packages/rs-platform-version/Cargo.toml(1 hunks)packages/rs-platform-versioning/Cargo.toml(1 hunks)packages/rs-sdk/Cargo.toml(1 hunks)packages/search-contract/Cargo.toml(1 hunks)packages/simple-signer/Cargo.toml(1 hunks)packages/strategy-tests/Cargo.toml(1 hunks)packages/token-history-contract/Cargo.toml(1 hunks)packages/token-history-contract/package.json(1 hunks)packages/wallet-lib/package.json(1 hunks)packages/wallet-utils-contract/Cargo.toml(1 hunks)packages/wallet-utils-contract/package.json(1 hunks)packages/wasm-dpp/Cargo.toml(1 hunks)packages/wasm-dpp/package.json(1 hunks)packages/withdrawals-contract/Cargo.toml(1 hunks)packages/withdrawals-contract/package.json(1 hunks)
💤 Files with no reviewable changes (1)
- packages/rs-dpp/src/data_contract/associated_token/token_perpetual_distribution/reward_distribution_type/evaluate_interval.rs
⏰ Context from checks skipped due to timeout of 90000ms (20)
- GitHub Check: Rust packages (drive-abci) / Check each feature
- GitHub Check: Rust packages (drive-abci) / Detect immutable structure changes
- GitHub Check: Rust packages (drive-abci) / Formatting
- GitHub Check: Rust packages (drive) / Unused dependencies
- GitHub Check: Rust packages (drive) / Tests
- GitHub Check: Rust packages (drive) / Formatting
- GitHub Check: Rust packages (drive) / Linting
- GitHub Check: Rust packages (dpp) / Tests
- GitHub Check: Rust packages (dpp) / Check each feature
- GitHub Check: Rust packages (dpp) / Unused dependencies
- GitHub Check: Rust packages (dpp) / Linting
- GitHub Check: Rust packages (dpns-contract) / Tests
- GitHub Check: Rust packages (dpns-contract) / Linting
- GitHub Check: Rust packages (dapi-grpc) / Check each feature
- GitHub Check: Rust packages (dash-sdk) / Check each feature
- GitHub Check: Rust packages (dash-sdk) / Tests
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build JS packages / Build JS
🔇 Additional comments (46)
packages/dashmate/package.json (1)
3-3: Major Version Bump Confirmed.
The version field is updated to"2.0.0-dev.1"as required. Ensure that this update is coordinated with version changes in the other packages.packages/rs-dpp/Cargo.toml (1)
3-3: Version Update Verification.
The package version is now"2.0.0-dev.1", reflecting the intended bump. Please double-check that all dependent components using this package have been updated accordingly.packages/masternode-reward-shares-contract/Cargo.toml (1)
4-4: Version Bump Confirmed.
The version is updated to"2.0.0-dev.1"on line 4. Verify that any related package metadata (e.g. in the accompanyingpackage.jsonfor this contract) is consistent with this change.packages/rs-platform-versioning/Cargo.toml (1)
5-5: Consistent Version Increment.
The version field on line 5 has been updated to"2.0.0-dev.1", which aligns with the new development stage. Ensure that documentation and any integration workflows are updated to reflect this new version.packages/rs-platform-value/Cargo.toml (1)
5-5: Version Bump Consistency Check.
The version has been bumped to"2.0.0-dev.1"on line 5. Confirm that downstream dependencies and consumers of this package are compatible with this version change.packages/check-features/Cargo.toml (1)
3-3: Version Bump Applied Correctly.
The package version has been updated to"2.0.0-dev.1", which clearly reflects the new development stage. Please ensure that any documentation or dependency references are updated accordingly.packages/rs-platform-value-convertible/Cargo.toml (1)
5-5: Version Update for Platform-Value-Convertible.
The version field has been bumped to"2.0.0-dev.1", aligning with the overall coordinated update across packages. Verify that consumers of this library are aware of the development-stage version.packages/wasm-dpp/Cargo.toml (1)
3-3: WASM-DPP Version Bump.
The package version is now set to"2.0.0-dev.1", consistent with the project's release strategy. Additionally, please double-check that any related build scripts (e.g., those involvingwasm-bindgen) and the accompanyingpackage.jsonupdates are synchronized with this change.packages/rs-platform-version/Cargo.toml (1)
5-5: Platform-Version Updated.
The version has been updated to"2.0.0-dev.1". This aligns with the release's new development tag. Verify that all dependent modules or consumers of this library are prepared for potential breaking changes due to the version increment.packages/rs-json-schema-compatibility-validator/Cargo.toml (1)
3-3: JSON Schema Compatibility Validator Version Updated.
The version change to"2.0.0-dev.1"is consistent with the coordinated roll-out across the project. This uniform approach helps maintain compatibility. Please ensure that any tests or integration flows that depend on this package are re-verified after the version update.packages/rs-drive-abci/Cargo.toml (1)
3-3: Version Bump Applied Correctly
The version update to"2.0.0-dev.1"is correctly applied in this package. This change aligns with the new development versioning and is consistent with our coordinated release update.packages/data-contracts/Cargo.toml (1)
4-4: Consistent Version Update
The update to"2.0.0-dev.1"for thedata-contractspackage is properly aligned with our overall version bump strategy.packages/dashpay-contract/Cargo.toml (1)
4-4: Version Bump Confirmed
Updating the version to"2.0.0-dev.1"here is in line with our development release. Please ensure that any tooling or downstream projects referencing this package are also updated accordingly.packages/rs-platform-serialization/Cargo.toml (1)
5-5: Version Update is Correct
Theplatform-serializationpackage now correctly reports its version as"2.0.0-dev.1". This change is consistent with the other packages and supports a uniform development version state.packages/rs-sdk/Cargo.toml (1)
2-4: Dash-SDK Version Updated Successfully
The version number change to"2.0.0-dev.1"in thedash-sdkpackage is handled appropriately. Ensure that any references to this package in dependency graphs or documentation reflect this update.packages/simple-signer/Cargo.toml (1)
3-3: Version Update for Simple-Signer
The package version has been updated to"2.0.0-dev.1"as intended. Please ensure that all related documentation (e.g., changelogs, release notes) and any dependent configurations are updated accordingly.packages/dapi-grpc/Cargo.toml (1)
4-4: Version Update for dapi-grpc
The package’s version change to"2.0.0-dev.1"is consistent with the project’s overall bump. Verify that corresponding version references (including those in the relatedpackage.json) are also updated to maintain consistency across the ecosystem.packages/strategy-tests/Cargo.toml (1)
3-3: Version Update for Strategy-Tests
The updated version"2.0.0-dev.1"meets the PR objective. It’s advisable to review any integration tests or CI/CD configurations that may reference the previous version to ensure a smooth transition.packages/rs-dapi-client/Cargo.toml (1)
3-3: Version Update for rs-dapi-client
This version bump to"2.0.0-dev.1"is aligned with the broader update. Please confirm that any consumers or dependent packages reflect this new version requirement to avoid compatibility issues.packages/search-contract/Cargo.toml (1)
4-4: Version Update for Search-Contract
The package version is now"2.0.0-dev.1", which harmonizes with the overall versioning strategy. Ensure that documentation and any dependency specifications elsewhere in the project are updated to match this new version.packages/wallet-lib/package.json (1)
3-3: Version Bump Consistency Check.
The package version has been updated to"9.0.0-dev.1". Please confirm that this divergence from the version pattern seen in other packages (which generally use"2.0.0-dev.1") is intentional. If this package follows a distinct versioning scheme, a brief note in the documentation might help avoid any future confusion.packages/wallet-utils-contract/Cargo.toml (1)
4-4: Cargo.toml Version Update Verification.
The version in this Cargo.toml has been updated to"2.0.0-dev.1". This change appears to be in line with the overall bump. Please ensure that this update is compatible with your workspace configuration and dependency tooling.packages/token-history-contract/Cargo.toml (1)
4-4: Token History Contract Version Update.
The version was bumped to"2.0.0-dev.1". This update is consistent with the other Rust package version changes. Verify that consuming projects and any associated integration tests account for this new development version.packages/js-dash-sdk/package.json (1)
3-3: JS Dash SDK Version Bump Confirmation.
The version has been updated to"5.0.0-dev.1", which seems to reflect the intended development release. It would be good to double-check that downstream consumers of this package are prepared for any potential breaking changes introduced by this update.packages/rs-drive-proof-verifier/Cargo.toml (1)
3-3: Drive Proof Verifier Version Update Check.
The version is now"2.0.0-dev.1", aligning with the new development release for Rust packages. Please confirm that this bump is synchronized with your overall versioning strategy for Rust components and that dependent modules are updated accordingly.packages/feature-flags-contract/Cargo.toml (1)
4-4: Version Bump UpdateThe package version has been correctly updated to
"2.0.0-dev.1", aligning with the overall version transition across the project.packages/rs-dapi-grpc-macros/Cargo.toml (1)
4-4: Version Bump UpdateThe version update to
"2.0.0-dev.1"is consistent and follows the coordinated development version strategy.packages/rs-platform-serialization-derive/Cargo.toml (1)
5-5: Version Bump UpdateThe updated version
"2.0.0-dev.1"is correctly applied, ensuring consistency with other packages.packages/withdrawals-contract/Cargo.toml (1)
4-4: Version Bump UpdateThe package version is correctly updated to
"2.0.0-dev.1", matching the development versioning strategy.packages/rs-drive/Cargo.toml (1)
4-4: Version Bump UpdateThe version field is updated to
"2.0.0-dev.1"as expected, aligning with the coordinated release strategy.package.json (1)
3-3: Version Bump Update in Root package.json
The version is updated to"2.0.0-dev.1", which aligns with the new development phase described in the PR objectives. Please ensure that accompanying documentation and changelogs reflect this update.packages/dapi/package.json (1)
4-4: Version Bump Applied to @dashevo/dapi
The version change to"2.0.0-dev.1"is clear and consistent with the rest of the project. This update appears correct; just verify that any integrations or deployments referencing this package use the new version.packages/wallet-utils-contract/package.json (1)
3-3: Consistent Version Update in @dashevo/wallet-utils-contract
The version has been updated to"2.0.0-dev.1", keeping it consistent with the overall project version bump. No issues found.packages/platform-test-suite/package.json (1)
4-4: Platform-Test-Suite Version Update Verified
The"version": "2.0.0-dev.1"update is correctly applied. Ensure that any version-specific test configurations are reviewed if needed.packages/dapi-grpc/package.json (1)
3-3: Version Update in @dashevo/dapi-grpc Confirmed
The package version is updated to"2.0.0-dev.1", which is consistent with other packages. Remember to check that corresponding files (e.g.,Cargo.tomlif applicable) are in sync with this version bump.packages/dpns-contract/Cargo.toml (1)
4-4: Version Bump in Cargo.toml
The package version has been updated to"2.0.0-dev.1", which aligns with the new development stage indicated by the PR. Please ensure that the changelog or any release notes are updated to reflect this version bump.packages/js-dapi-client/package.json (1)
3-3: Update Version in js-dapi-client
The version has been updated to"2.0.0-dev.1", maintaining consistency with the overall project version update. No further issues detected in this segment.packages/dpns-contract/package.json (1)
2-3: Version Update in dpns-contract Package Metadata
The version field is now"2.0.0-dev.1", consistent with the Cargo.toml update. Ensure any backward‐incompatible changes (if present) are clearly documented in the release notes or migration guides for downstream users.packages/js-grpc-common/package.json (1)
2-3: Version Bump in js-grpc-common
The version update to"2.0.0-dev.1"is in line with the coordinated version changes across the project. This change appears correct and maintains internal consistency.packages/token-history-contract/package.json (1)
2-3: Raise Version for token-history-contract
The version has been updated from"1.8.0-dev.2"to"2.0.0-dev.1". This major version increment may indicate breaking changes or significant updates. Please verify that any such changes are documented and that users are provided with migration guidance if needed.packages/dashpay-contract/package.json (1)
2-3: Version Bump Verification for Dashpay Contract
The version has been updated to"2.0.0-dev.1"as intended. This is consistent with the overall development phase update. Please ensure that any documentation or tooling referencing the previous version is also updated.packages/withdrawals-contract/package.json (1)
2-3: Version Update Confirmation for Withdrawals Contract
The package version has been correctly updated to"2.0.0-dev.1". Confirm that integration tests or scripts relying on version identifiers are aligned with this change.packages/masternode-reward-shares-contract/package.json (1)
2-3: Version Bump Check for Masternode Reward Shares Contract
The version is now"2.0.0-dev.1", matching the global update. Ensure that any peer dependencies or documentation note this change if they previously referenced version1.8.0.packages/wasm-dpp/package.json (1)
2-3: WASM-DPP Version Update Verification
The version in this package has been bumped to"2.0.0-dev.1". This update is in line with the new development cycle. It would be prudent to check that any build scripts or CI configurations that depend on this version are updated accordingly.packages/feature-flags-contract/package.json (1)
2-3: Feature Flags Contract Version Bump Confirmation
The version has been updated to"2.0.0-dev.1", adhering to the coordinated project-wide update. Verify that any references to the previous version in documentation or dependency configurations are revised.packages/bench-suite/package.json (1)
4-4: Bump Version Update VerifiedThe version has been updated correctly to "2.0.0-dev.1", aligning with the planned development stage for this release. Ensure that downstream packages and documentation are updated accordingly if they reference the version explicitly.
QuantumExplorer
changed the title
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/dashmate/configs/getConfigFileMigrationsFactory.js (1)
1072-1072: Consider alternative todeleteoperatorThe static analysis tool flags the use of
deleteoperator which can potentially impact performance.- delete options.core.miner.mediantime; + options.core.miner.mediantime = undefined;However, since this pattern is used consistently throughout the codebase, you may want to address this globally in a separate refactoring effort rather than just here.
🧰 Tools
🪛 Biome (1.9.4)
[error] 1072-1072: Avoid the delete operator which can impact performance.
Unsafe fix: Use an undefined assignment instead.
(lint/performance/noDelete)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/dashmate/configs/getConfigFileMigrationsFactory.js(1 hunks)
🧰 Additional context used
🪛 Biome (1.9.4)
packages/dashmate/configs/getConfigFileMigrationsFactory.js
[error] 1072-1072: Avoid the delete operator which can impact performance.
Unsafe fix: Use an undefined assignment instead.
(lint/performance/noDelete)
⏰ Context from checks skipped due to timeout of 90000ms (17)
- GitHub Check: Rust packages (dash-sdk) / Check each feature
- GitHub Check: Rust packages (dash-sdk) / Unused dependencies
- GitHub Check: Rust packages (dash-sdk) / Formatting
- GitHub Check: Rust packages (dash-sdk) / Linting
- GitHub Check: Rust packages (dashpay-contract) / Tests
- GitHub Check: Rust packages (dashpay-contract) / Unused dependencies
- GitHub Check: Rust packages (dpns-contract) / Tests
- GitHub Check: Rust packages (dashpay-contract) / Linting
- GitHub Check: Rust packages (dpns-contract) / Unused dependencies
- GitHub Check: Rust packages (dpns-contract) / Linting
- GitHub Check: Rust packages (dapi-grpc) / Tests
- GitHub Check: Rust packages (dapi-grpc) / Unused dependencies
- GitHub Check: Rust packages (dapi-grpc) / Check each feature
- GitHub Check: Rust packages (dapi-grpc) / Linting
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
- GitHub Check: Build JS packages / Build JS
🔇 Additional comments (1)
packages/dashmate/configs/getConfigFileMigrationsFactory.js (1)
1069-1078: LGTM: New migration for version 2.0.0-dev.1This migration function appropriately updates Docker image references to the new version (2-dev) and removes the
mediantimeproperty from core.miner, following the established pattern from previous migrations.🧰 Tools
🪛 Biome (1.9.4)
[error] 1072-1072: Avoid the delete operator which can impact performance.
Unsafe fix: Use an undefined assignment instead.
(lint/performance/noDelete)
chore: update to latest dash core 37 (#2483) feat(platform)!: token advanced distribution and updates (#2471) fix: token history contract (#2474) Co-authored-by: Ivan Shumkov <ivan@shumkov.ru> Co-authored-by: QuantumExplorer <quantum@dash.org> fix(drive): using new rust dash core methods for reversed quorum hash to maintain backwards compatibility (#2489) feat: more granular integer document property types (#2455) Co-authored-by: Quantum Explorer <quantum@dash.org> docs: update comment for data contract code range (#2476) feat: validate token name localizations (#2468) feat(sdk): get identity by non-unique keys build(deps): update grovedb to current develop test: test identity by non-unique pubkey hashes fix(sdk): dash core client fails to get quorum chore: minor fixes test(drive-abci): identity by non-unique pubkey start after chore: minor changes to verify feat(sdk): token and group queries (#2449) chore: revert limit 1 => limit none chore: add non-unique key to test identities test(sdk): test vectors for test_fetch_identity_by_non_unique_public_keys fix(platform)!: token distribution fixes and tests (#2494) chore(platform): bump to version 2.0.0-dev.1 (#2495) test: update assertion fix(sdk): make some things public (#2496) feat(platform): require token for document actions (#2498) fix: data contract proof doesn't work with new auto fields (#2501)
chore: update to latest dash core 37 (#2483) feat(platform)!: token advanced distribution and updates (#2471) fix: token history contract (#2474) Co-authored-by: Ivan Shumkov <ivan@shumkov.ru> Co-authored-by: QuantumExplorer <quantum@dash.org> fix(drive): using new rust dash core methods for reversed quorum hash to maintain backwards compatibility (#2489) feat: more granular integer document property types (#2455) Co-authored-by: Quantum Explorer <quantum@dash.org> docs: update comment for data contract code range (#2476) feat: validate token name localizations (#2468) feat(sdk): get identity by non-unique keys build(deps): update grovedb to current develop test: test identity by non-unique pubkey hashes fix(sdk): dash core client fails to get quorum chore: minor fixes test(drive-abci): identity by non-unique pubkey start after chore: minor changes to verify feat(sdk): token and group queries (#2449) chore: revert limit 1 => limit none chore: add non-unique key to test identities test(sdk): test vectors for test_fetch_identity_by_non_unique_public_keys fix(platform)!: token distribution fixes and tests (#2494) chore(platform): bump to version 2.0.0-dev.1 (#2495) test: update assertion fix(sdk): make some things public (#2496) feat(platform): require token for document actions (#2498) fix: data contract proof doesn't work with new auto fields (#2501)
Summary by CodeRabbit
Chores
Refactor