-
Notifications
You must be signed in to change notification settings - Fork 43
chore: bump to v2.0.0-rc.4 #2579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis update increments the version numbers across multiple package manifest files within the repository, moving from release candidate 3 ( Changes
Possibly related PRs
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
packages/rs-platform-versioning/Cargo.toml (1)
1-17
: 💡 Verification agent🧩 Analysis chain
Verify consistency across all manifest files.
Please ensure that all relatedCargo.toml
crates and anypackage.json
or other manifest files in the workspace have also been bumped from2.0.0-rc.3
to2.0.0-rc.4
.Run the following script to detect any remaining
rc.3
references:
🏁 Script executed:
#!/bin/bash # Search for lingering rc.3 version markers across the repo rg -n 'rc\.3' .Length of output: 1640
Remaining
rc.3
references detected—please bump torc.4
The script uncovered several lingering2.0.0-rc.3
(and one1.8.0-rc.3
) reference. Please update each torc.4
, regenerate the lockfile, and verify no other manifests linger onrc.3
.• packages/wasm-dpp/Cargo.toml (line 58)
• packages/strategy-tests/Cargo.toml (line 16)
• packages/rs-platform-version/Cargo.toml (line 12)
• packages/simple-signer/Cargo.toml (line 10)
• packages/rs-platform-serialization/Cargo.toml (line 11)
• packages/rs-platform-value/Cargo.toml (line 11)
• packages/rs-drive-proof-verifier/Cargo.toml (line 35)
• packages/rs-drive-abci/Cargo.toml (line 17)
• packages/rs-drive/Cargo.toml (line 17)
• packages/rs-dpp/Cargo.toml
– line 42:bincode = { version = "=2.0.0-rc.3", features = ["serde"] }
– line 43:bincode_derive = { version = "=2.0.0-rc.3" }
– line 304: comment referencingrc.3
• packages/js-dapi-client/lib/test/fixtures/getStatusFixture.js (line 9):drive: '1.8.0-rc.3'
• Cargo.lock (multiple entries for2.0.0-rc.3
)Example diffs:
-bincode = { version = "=2.0.0-rc.3", features = ["serde"] } +bincode = { version = "=2.0.0-rc.4", features = ["serde"] }-drive: '1.8.0-rc.3', +drive: '1.8.0-rc.4',After updating, run:
cargo update -p bincode --precise 2.0.0-rc.4to regenerate
Cargo.lock
.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
Cargo.lock
is excluded by!**/*.lock
📒 Files selected for processing (46)
package.json
(1 hunks)packages/bench-suite/package.json
(1 hunks)packages/check-features/Cargo.toml
(1 hunks)packages/dapi-grpc/Cargo.toml
(1 hunks)packages/dapi-grpc/package.json
(1 hunks)packages/dapi/package.json
(1 hunks)packages/dashmate/package.json
(1 hunks)packages/dashpay-contract/Cargo.toml
(1 hunks)packages/dashpay-contract/package.json
(1 hunks)packages/data-contracts/Cargo.toml
(1 hunks)packages/dpns-contract/Cargo.toml
(1 hunks)packages/dpns-contract/package.json
(1 hunks)packages/feature-flags-contract/Cargo.toml
(1 hunks)packages/feature-flags-contract/package.json
(1 hunks)packages/js-dapi-client/package.json
(1 hunks)packages/js-dash-sdk/package.json
(1 hunks)packages/js-grpc-common/package.json
(1 hunks)packages/keyword-search-contract/Cargo.toml
(1 hunks)packages/masternode-reward-shares-contract/Cargo.toml
(1 hunks)packages/masternode-reward-shares-contract/package.json
(1 hunks)packages/platform-test-suite/package.json
(1 hunks)packages/rs-dapi-client/Cargo.toml
(1 hunks)packages/rs-dapi-grpc-macros/Cargo.toml
(1 hunks)packages/rs-dpp/Cargo.toml
(1 hunks)packages/rs-drive-abci/Cargo.toml
(1 hunks)packages/rs-drive-proof-verifier/Cargo.toml
(1 hunks)packages/rs-drive/Cargo.toml
(1 hunks)packages/rs-json-schema-compatibility-validator/Cargo.toml
(1 hunks)packages/rs-platform-serialization-derive/Cargo.toml
(1 hunks)packages/rs-platform-serialization/Cargo.toml
(1 hunks)packages/rs-platform-value-convertible/Cargo.toml
(1 hunks)packages/rs-platform-value/Cargo.toml
(1 hunks)packages/rs-platform-version/Cargo.toml
(1 hunks)packages/rs-platform-versioning/Cargo.toml
(1 hunks)packages/rs-sdk/Cargo.toml
(1 hunks)packages/simple-signer/Cargo.toml
(1 hunks)packages/strategy-tests/Cargo.toml
(1 hunks)packages/token-history-contract/Cargo.toml
(1 hunks)packages/token-history-contract/package.json
(1 hunks)packages/wallet-lib/package.json
(1 hunks)packages/wallet-utils-contract/Cargo.toml
(1 hunks)packages/wallet-utils-contract/package.json
(1 hunks)packages/wasm-dpp/Cargo.toml
(1 hunks)packages/wasm-dpp/package.json
(1 hunks)packages/withdrawals-contract/Cargo.toml
(1 hunks)packages/withdrawals-contract/package.json
(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: QuantumExplorer
PR: dashpay/platform#2257
File: packages/rs-drive-abci/src/mimic/test_quorum.rs:159-164
Timestamp: 2024-11-20T16:16:01.830Z
Learning: QuantumExplorer prefers not to receive auto-generated messages asking to post on social media.
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build JS packages / Build JS
🔇 Additional comments (48)
packages/data-contracts/Cargo.toml (1)
4-4
: Approve version bump to 2.0.0-rc.4The
version
field has been correctly updated from2.0.0-rc.3
to2.0.0-rc.4
with no unintended changes to other metadata or dependencies.packages/rs-json-schema-compatibility-validator/Cargo.toml (1)
3-3
: Approve version bump to 2.0.0-rc.4
The crate’s version has been correctly updated to align with the repository-wide release candidate increment. No other metadata or dependencies were modified.packages/rs-drive/Cargo.toml (1)
4-4
: Version bump to2.0.0-rc.4
The package version has been correctly updated from2.0.0-rc.3
to2.0.0-rc.4
.packages/rs-dpp/Cargo.toml (1)
3-3
: Crate version bump to 2.0.0-rc.4
The package version has been correctly updated from2.0.0-rc.3
to2.0.0-rc.4
. All other fields remain unchanged and in sync with the release process.packages/bench-suite/package.json (1)
4-4
: Package version bump to 2.0.0-rc.4
Theversion
field has been updated consistently with the coordinated RC release. No further adjustments are necessary here.packages/js-dash-sdk/package.json (1)
3-3
: Package version bump to 5.0.0-rc.4
Version correctly incremented to match the RC-4 rollout across the monorepo.packages/dapi-grpc/Cargo.toml (1)
4-4
: Crate version bump to 2.0.0-rc.4
The version field aligns with the coordinated release candidate update.packages/simple-signer/Cargo.toml (1)
3-3
: Crate version bump to 2.0.0-rc.4
The crate version is updated as expected. Ensure downstream workflows pick up this new tag.packages/withdrawals-contract/Cargo.toml (1)
4-4
: Approve version bump. Thewithdrawals-contract
crate has been correctly updated from2.0.0-rc.3
to2.0.0-rc.4
.packages/rs-drive-abci/Cargo.toml (1)
3-3
: Approve version bump. Thedrive-abci
crate version is now2.0.0-rc.4
, matching the coordinated release candidate update.packages/rs-platform-serialization/Cargo.toml (1)
5-5
: Approve version bump. Theplatform-serialization
crate version has been correctly updated to2.0.0-rc.4
.packages/rs-platform-value/Cargo.toml (1)
5-5
: Approve version bump. Theplatform-value
crate version is now2.0.0-rc.4
, consistent with the release candidate rollout.packages/rs-drive-proof-verifier/Cargo.toml (1)
3-3
: Approve version bump. Thedrive-proof-verifier
crate has been updated to version2.0.0-rc.4
as part of the coordinated rc.4 release.packages/js-grpc-common/package.json (1)
3-3
: Consistent version bump to 2.0.0-rc.4
The package version has been updated correctly to align with the coordinated release candidate update. No other metadata or dependency changes are necessary.packages/js-dapi-client/package.json (1)
3-3
: Consistent version bump to 2.0.0-rc.4
Version updated in lockstep with the rest of the repository’s packages. No downstream impact expected.packages/wallet-lib/package.json (1)
3-3
: Consistent version bump to 9.0.0-rc.4
Wallet library version incremented as part of the RC.4 release. All scripts and dependencies remain unchanged.packages/dashpay-contract/Cargo.toml (1)
4-4
: Consistent version bump to 2.0.0-rc.4
Rust contract version updated to the new release candidate. Dependencies and workspace settings are intact.packages/dpns-contract/Cargo.toml (1)
4-4
: Consistent version bump to 2.0.0-rc.4
DPNS contract version aligned with the global RC.4 bump. No further changes required.packages/wallet-utils-contract/Cargo.toml (1)
4-4
: Approve version bump to 2.0.0-rc.4
The package version has been correctly updated from2.0.0-rc.3
to2.0.0-rc.4
, aligning with the coordinated release across the repository.packages/dashmate/package.json (1)
3-3
: Approve version bump to 2.0.0-rc.4
Theversion
field has been updated appropriately indashmate
’spackage.json
, consistent with the repository-wide release candidate update.packages/feature-flags-contract/Cargo.toml (1)
4-4
: Approve version bump to 2.0.0-rc.4
Thefeature-flags-contract
crate version has been correctly incremented to2.0.0-rc.4
, in lockstep with other contract packages.packages/rs-platform-value-convertible/Cargo.toml (1)
5-5
: Approve version bump to 2.0.0-rc.4
Theplatform-value-convertible
crate version has been updated to2.0.0-rc.4
, maintaining consistency across Rust packages.packages/rs-platform-serialization-derive/Cargo.toml (1)
5-5
: Approve version bump to 2.0.0-rc.4
Theplatform-serialization-derive
crate version is now2.0.0-rc.4
, matching the release candidate update in related crates.packages/rs-dapi-grpc-macros/Cargo.toml (1)
4-4
: Version bump to 2.0.0-rc.4
Theversion
field was correctly updated from2.0.0-rc.3
to2.0.0-rc.4
.packages/check-features/Cargo.toml (1)
3-3
: Version bump to 2.0.0-rc.4
Theversion
field was correctly updated from2.0.0-rc.3
to2.0.0-rc.4
.packages/token-history-contract/Cargo.toml (1)
4-4
: Version bump to 2.0.0-rc.4
Theversion
field was correctly updated from2.0.0-rc.3
to2.0.0-rc.4
.packages/masternode-reward-shares-contract/Cargo.toml (1)
4-4
: Version bump to 2.0.0-rc.4
Theversion
field was correctly updated from2.0.0-rc.3
to2.0.0-rc.4
.packages/dashpay-contract/package.json (1)
3-3
: Version bump to 2.0.0-rc.4
Theversion
property was correctly updated from2.0.0-rc.3
to2.0.0-rc.4
.packages/dpns-contract/package.json (1)
3-3
: Approve version bump to 2.0.0-rc.4Updated version from
2.0.0-rc.3
to2.0.0-rc.4
, consistent with the repository-wide coordinated release candidate increment.packages/rs-dapi-client/Cargo.toml (1)
3-3
: Approve version bump to 2.0.0-rc.4Cargo package version has been correctly updated from
2.0.0-rc.3
to2.0.0-rc.4
, matching other crates in this release.packages/wallet-utils-contract/package.json (1)
3-3
: Approve version bump to 2.0.0-rc.4Version updated to
2.0.0-rc.4
to align with the coordinated bump across all contract packages.packages/token-history-contract/package.json (1)
3-3
: Approve version bump to 2.0.0-rc.4Consistent version update from
2.0.0-rc.3
to2.0.0-rc.4
, in line with the broader release candidate rollout.packages/feature-flags-contract/package.json (1)
3-3
: Approve version bump to 2.0.0-rc.4The feature-flags contract package version has been correctly incremented to
2.0.0-rc.4
.packages/wasm-dpp/Cargo.toml (1)
3-3
: Version bumped to 2.0.0-rc.4 as expected
The Cargo manifest’s version field has been updated in line with the coordinated RC release.packages/dapi/package.json (1)
4-4
: Version updated to 2.0.0-rc.4
The package.json version bump matches the repository-wide release candidate increment.packages/rs-sdk/Cargo.toml (1)
3-3
: Cargo version set to 2.0.0-rc.4
The version aligns with other Rust and JS packages for the RC.packages/wasm-dpp/package.json (1)
3-3
: Package version bumped to 2.0.0-rc.4
This update is consistent with the coordinated version bump across all @dashevo/* packages.package.json (1)
3-3
: Root version updated to 2.0.0-rc.4
The @dashevo/platform package.json version now reflects the RC.4 release.packages/withdrawals-contract/package.json (1)
3-3
: Approve version bump
The package version has been correctly updated from2.0.0-rc.3
to2.0.0-rc.4
, matching the coordinated release candidate increment.packages/dapi-grpc/package.json (1)
3-3
: Approve version bump
The package version has been correctly updated from2.0.0-rc.3
to2.0.0-rc.4
, aligning with the repository-wide release candidate update.packages/platform-test-suite/package.json (1)
4-4
: Approve version bump
The private package version has been correctly updated from2.0.0-rc.3
to2.0.0-rc.4
in accordance with the PR objectives.packages/masternode-reward-shares-contract/package.json (1)
3-3
: Approve version bump
The package version has been correctly updated from2.0.0-rc.3
to2.0.0-rc.4
, consistent with the coordinated version sync.packages/strategy-tests/Cargo.toml (1)
3-3
: Consistent version bump
Theversion
field has been correctly updated from2.0.0-rc.3
to2.0.0-rc.4
, aligning this crate with the coordinated release across the ecosystem.packages/rs-platform-version/Cargo.toml (2)
5-5
: Version bump to 2.0.0-rc.4 is correct.
This aligns with the PR objective to advance fromrc.3
torc.4
.
5-5
:✅ Verification successful
Verify version consistency across all Rust crates.
Please ensure no remaining2.0.0-rc.3
references in otherCargo.toml
files.
🏁 Script executed:
#!/bin/bash # Search for any lingering rc.3 version strings in Cargo.toml files rg -l '"2\.0\.0-rc\.3"' -g '*/Cargo.toml'Length of output: 192
🏁 Script executed:
#!/bin/bash # Search for any lingering 2.0.0-rc.3 references in all Cargo.toml files find . -type f -name 'Cargo.toml' -exec grep -H '"2\.0\.0-rc\.3"' {} \;Length of output: 74
No remaining
2.0.0-rc.3
references found across all Cargo.toml files. All Rust crates are now consistently updated to2.0.0-rc.4
.packages/keyword-search-contract/Cargo.toml (2)
4-4
: Approve version bump: The version field has been correctly updated from2.0.0-rc.3
to2.0.0-rc.4
.
4-4
: 💡 Verification agent🧩 Analysis chain
Verify no stale references to the old version: Ensure that all occurrences of
2.0.0-rc.3
have been updated across the repo. You can use this script to detect any lingering references:
🏁 Script executed:
#!/bin/bash # Search for any remaining rc.3 version strings in manifest files rg -n "2\.0\.0-rc\.3"Length of output: 1269
Action Required: Update all lingering
2.0.0-rc.3
references
The grep run shows multiple crates and the lockfile still pinningbincode = "2.0.0-rc.3"
. Please update them to2.0.0-rc.4
and regenerate your lockfile.Affected files (examples):
- Cargo.lock (lines 427, 437)
- packages/wasm-dpp/Cargo.toml:58
- packages/simple-signer/Cargo.toml:10
- packages/strategy-tests/Cargo.toml:16
- packages/rs-platform-value/Cargo.toml:11
- packages/rs-platform-version/Cargo.toml:12
- packages/rs-platform-serialization/Cargo.toml:11
- packages/rs-drive-abci/Cargo.toml:17
- packages/rs-drive-proof-verifier/Cargo.toml:35
- packages/rs-drive/Cargo.toml:17
- packages/rs-dpp/Cargo.toml:42,43,304
Suggested steps:
- In each
Cargo.toml
, change- bincode = { version = "=2.0.0-rc.3", … } + bincode = { version = "=2.0.0-rc.4", … }- Run
cargo update -p bincode --precise 2.0.0-rc.4
(or fullcargo update
) to bump the lockfile.- Re-run
rg -n "2\.0\.0-rc\.3"
to confirm no stale entries remain.Likely an incorrect or invalid review comment.
packages/rs-platform-versioning/Cargo.toml (1)
5-5
: Approve version bump to2.0.0-rc.4
.
The version metadata has been correctly updated fromrc.3
torc.4
.
Summary by CodeRabbit