Fix broken debugging caused by missing CallFrame.url #1559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annagrin
force-pushed
the
annagrin/chrome-100
branch
from
a94653e to
809bfec
Compare
elliette
reviewed
Apr 5, 2022
natebosch
reviewed
Apr 5, 2022
elliette
approved these changes
Apr 5, 2022
|
Great to see this one fixed! I'm not familiar with the process, how that fix will be distributed? Is it going to be part of the next Flutter update? If yes, anyway to get it before? Thanks!!! |
|
Great work on the fast fix! Could anyone let me know when this is available on (flutter/dart)stable, as currently I am unable to properly test my code and downgrading chrome is not an option for me. Thanks EDIT; also if anyone has a timeframe that would also be helpful |
|
@Statyk7 , @florisdipt You can follow from here to see the current status in Flutter as well as some steps to manually apply the fix if you need to (as of writing, merged to master, but backport for stable is still pending): flutter/flutter#101224 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently Chromium deprecated the CallFrame.url field in the debugger protocol:
https://bugs.chromium.org/p/chromium/issues/detail?id=1270316
https://chromium.googlesource.com/v8/v8/+/21f72f82ce854762d6bc1c780d3b108dc1947f5d
Use
remoteDebugger.scriptsinstead ofCallFrame.urlto look up the frame url from a chrome script id.Closes: #1557
Related: flutter/flutter#101224