Fix broken debugging caused by missing CallFrame.url

Author: Anna Gringauze

dwds/CHANGELOG.md

@@ -16,6 +16,7 @@
 - Update error message on expression evaluation using unloaded libraries.
 - Add `screen` field to the `DebuggerReady` event.
 - Report `DebuggerReady` events for DevTools embedded into Chrome Devtools.
+- Fix missing `CallFrame.url` after update to Chrome 100.
 
 **Breaking changes:**
 - `Dwds.start` and `ExpressionCompilerService` now take

dwds/debug_extension/web/background.dart

@@ -575,8 +575,6 @@ void _filterAndForwardToBackend(Debuggee source, String method, Object params) {
 
   if (debugSession == null) return;
 
-  if (method == 'Debugger.scriptParsed') return;
-
   var event = _extensionEventFor(method, params);
 
   debugSession.socketClient.sink.add(jsonEncode(serializers.serialize(event)));

dwds/debug_extension/web/background.js

@@ -312,15 +312,21 @@ class Debugger extends Domain {
     }
   }
 
+  String urlForScriptId(String scriptId) =>
+      _remoteDebugger.scripts[scriptId]?.url;
+
   /// Returns source [Location] for the paused event.
   ///
   /// If we do not have [Location] data for the embedded JS location, null is
   /// returned.
   Future<Location> _sourceLocation(DebuggerPausedEvent e) {
     var frame = e.params['callFrames'][0];
     var location = frame['location'];
-    return _locations.locationForJs(
-        frame['url'] as String, (location['lineNumber'] as int) + 1);
+    var scriptId = location['scriptId'] as String;
+    var lineNumber = location['lineNumber'] as int;
+
+    var url = urlForScriptId(scriptId);
+    return _locations.locationForJs(url, lineNumber + 1);
   }
 
   /// The variables visible in a frame in Dart protocol [BoundVariable] form.
@@ -458,7 +464,8 @@ class Debugger extends Domain {
     // TODO(sdk/issues/37240) - ideally we look for an exact location instead
     // of the closest location on a given line.
     Location bestLocation;
-    for (var location in await _locations.locationsForUrl(frame.url)) {
+    var url = urlForScriptId(location.scriptId);
+    for (var location in await _locations.locationsForUrl(url)) {
       if (location.jsLocation.line == line) {
         bestLocation ??= location;
         if ((location.jsLocation.column - column).abs() <
@@ -558,8 +565,9 @@ class Debugger extends Domain {
       // If we don't have source location continue stepping.
       if (_isStepping && (await _sourceLocation(e)) == null) {
         var frame = e.params['callFrames'][0];
-        var url = '${frame["url"]}';
         var scriptId = '${frame["location"]["scriptId"]}';
+        var url = urlForScriptId(scriptId);
+
         // TODO(grouma) - In the future we should send all previously computed
         // skipLists.
         await _remoteDebugger.stepInto(params: {

dwds/lib/src/debugging/debugger.dart

@@ -20,9 +20,6 @@ class Modules {
   final _sourceToLibrary = <String, Uri>{};
   var _moduleMemoizer = AsyncMemoizer<void>();
 
-  // The Chrome script ID to corresponding module.
-  final _scriptIdToModule = <String, String>{};
-
   final Map<String, String> _libraryToModule = {};
 
   String _entrypoint;
@@ -43,9 +40,6 @@ class Modules {
     _entrypoint = entrypoint;
   }
 
-  /// Returns the module for the Chrome script ID.
-  String moduleForScriptId(String scriptId) => _scriptIdToModule[scriptId];
-
   /// Returns the containing module for the provided Dart server path.
   Future<String> moduleForSource(String serverPath) async {
     await _moduleMemoizer.runOnce(_initializeMapping);

dwds/lib/src/debugging/modules.dart

@@ -160,6 +160,7 @@ class ExpressionEvaluator {
 
     var functionName = jsFrame.functionName;
     var jsLine = jsFrame.location.lineNumber + 1;
+    var jsScriptId = jsFrame.location.scriptId;
     var jsScope = await _collectLocalJsScope(jsFrame);
 
     // Find corresponding dart location and scope.
@@ -169,12 +170,13 @@ class ExpressionEvaluator {
     // so this will result in expressions not evaluated in some
     // cases. Invent location matching strategy for those cases.
     // [issue 890](https://github.com/dart-lang/webdev/issues/890)
-    var locationMap = await _locations.locationForJs(jsFrame.url, jsLine);
+    var url = urlForScriptId(jsScriptId);
+    var locationMap = await _locations.locationForJs(url, jsLine);
     if (locationMap == null) {
       return _createError(
           ErrorKind.internal,
           'Cannot find Dart location for JS location: '
-          'url: ${jsFrame.url}'
+          'url: $url, '
           'function: $functionName, '
           'line: $jsLine');
     }
@@ -321,4 +323,7 @@ class ExpressionEvaluator {
 
     return jsScope;
   }
+
+  String urlForScriptId(String scriptId) =>
+      _inspector.remoteDebugger.scripts[scriptId]?.url;
 }

dwds/lib/src/injected/client.js

@@ -17,7 +17,7 @@ import 'package:dwds/src/loaders/strategy.dart';
 import 'package:test/test.dart';
 import 'package:vm_service/vm_service.dart';
 import 'package:webkit_inspection_protocol/webkit_inspection_protocol.dart'
-    show CallFrame, DebuggerPausedEvent, StackTrace, WipCallFrame;
+    show CallFrame, DebuggerPausedEvent, StackTrace, WipCallFrame, WipScript;
 
 import 'fixtures/context.dart';
 import 'fixtures/debugger_data.dart';
@@ -72,22 +72,31 @@ final sampleSyncFrame = WipCallFrame({
     'columnNumber': 72,
   },
   'location': {'scriptId': '69', 'lineNumber': 37, 'columnNumber': 0},
-  'url': 'http://127.0.0.1:8081/foo.ddc.js',
+  'url': '',
   'scopeChain': [],
   'this': {'type': 'undefined'},
 });
 
 final sampleAsyncFrame = CallFrame({
   'functionName': 'myFunc',
-  'url': 'http://127.0.0.1:8081/bar.ddc.js',
+  'url': '',
   'scriptId': '71',
   'lineNumber': 40,
   'columnNumber': 1,
 });
 
+final Map<String, WipScript> scripts = {
+  '69': WipScript(<String, dynamic>{
+    'url': 'http://127.0.0.1:8081/foo.ddc.js',
+  }),
+  '71': WipScript(<String, dynamic>{
+    'url': 'http://127.0.0.1:8081/bar.ddc.js',
+  }),
+};
+
 void main() async {
   setUpAll(() async {
-    webkitDebugger = FakeWebkitDebugger();
+    webkitDebugger = FakeWebkitDebugger(scripts: scripts);
     pausedController = StreamController<DebuggerPausedEvent>();
     webkitDebugger.onPaused = pausedController.stream;
     globalLoadStrategy = TestStrategy();

dwds/lib/src/services/expression_evaluator.dart

@@ -115,9 +115,6 @@ class FakeModules implements Modules {
     throw UnimplementedError();
   }
 
-  @override
-  String moduleForScriptId(String serverId) => '';
-
   @override
   Future<String> moduleForSource(String serverPath) {
     throw UnimplementedError();
@@ -135,13 +132,14 @@ class FakeModules implements Modules {
 }
 
 class FakeWebkitDebugger implements WebkitDebugger {
+  final Map<String, WipScript> _scripts;
   @override
   Future disable() => null;
 
   @override
   Future enable() => null;
 
-  FakeWebkitDebugger() {
+  FakeWebkitDebugger({Map<String, WipScript> scripts}) : _scripts = scripts {
     globalLoadStrategy = RequireStrategy(
         ReloadConfiguration.none,
         (_) async => {},
@@ -185,7 +183,7 @@ class FakeWebkitDebugger implements WebkitDebugger {
   Future<WipResponse> resume() => null;
 
   @override
-  Map<String, WipScript> get scripts => null;
+  Map<String, WipScript> get scripts => _scripts;
 
   List<WipResponse> results = variables1;
   int resultsReturned = 0;