Skip to content

Fix broken debugging caused by missing CallFrame.url #1559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 5, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dwds/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
- Update error message on expression evaluation using unloaded libraries.
- Add `screen` field to the `DebuggerReady` event.
- Report `DebuggerReady` events for DevTools embedded into Chrome Devtools.
- Fix missing `CallFrame.url` after update to Chrome 100.

**Breaking changes:**
- `Dwds.start` and `ExpressionCompilerService` now take
Expand Down
4 changes: 4 additions & 0 deletions dwds/debug_extension/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 1.28

- Support Chrome 100 updates to the remote debugging protocol.

## 1.27

- Support embedded debugger and inspector in Chrome DevTools for Flutter Web apps.
Expand Down
2 changes: 1 addition & 1 deletion dwds/debug_extension/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: extension
publish_to: none
version: 1.27.0
version: 1.28.0
homepage: https://github.com/dart-lang/webdev
description: >-
A chrome extension for Dart debugging.
Expand Down
2 changes: 0 additions & 2 deletions dwds/debug_extension/web/background.dart
Original file line number Diff line number Diff line change
Expand Up @@ -575,8 +575,6 @@ void _filterAndForwardToBackend(Debuggee source, String method, Object params) {

if (debugSession == null) return;

if (method == 'Debugger.scriptParsed') return;

var event = _extensionEventFor(method, params);

debugSession.socketClient.sink.add(jsonEncode(serializers.serialize(event)));
Expand Down
Loading