Remote service enhancement (applied to updated SlimBrowse Metadata) #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: darrell-k <darrell@darrell.org.uk>
Signed-off-by: darrell-k <darrell@darrell.org.uk>
…the Docker build Signed-off-by: Michael Herger <michael@herger.net>
Signed-off-by: Michael Herger <michael@herger.net>
darrell-k
commented
Nov 9, 2025
| cover => $subFeed->{'cover'} || $subFeed->{'image'} || $subFeed->{'icon'} || $request->getParam('icon'), | ||
| year => $subFeed->{'year'}, | ||
| album => $subFeed->{'album'}, | ||
| artist => $subFeed->{'artist'}, |
Owner
Author
There was a problem hiding this comment.
Not sure about these _cliQuery_done changes: may be left over from my branch which included changes for Default and Classic skins?
darrell-k
commented
Nov 9, 2025
| 'sortBy' => $attributes->{$tag.'SORT'}, | ||
| # only store EXTID for track artist, as we don't have it for other roles | ||
| 'extid' => $tag eq 'ARTIST' && $attributes->{'ARTIST_EXTID'}, | ||
| 'extid' => $attributes->{"${tag}_EXTID"}, |
Owner
Author
There was a problem hiding this comment.
These Slim::Schema changes just ensure we populate *_EXTID for all roles for which we have it, certainly the Qobuz plugin provides extid for Composers, at least.
Could be made into a separate PR, hopefully uncontroversial?
Signed-off-by: Michael Herger <michael@herger.net>
# Conflicts: # HTML/EN/settings/wizard.json # strings.txt
… those lists change too often. Signed-off-by: Michael Herger <michael@herger.net>
Signed-off-by: Michael Herger <michael@herger.net>
…rarchies This change moves playlist related images from the 'Default skin' hierarchy to the generic fallback 'EN' hierarchy. They are used to generate Squeezeplay icons. At present, they will not be found, and icons will not be generated, unless the user is using the 'Default' skin. Moving to 'EN' ensures they will be found, and icons generated, regardless of the skin in use. The change also removes the 'cover.png' and 'radio.png' images from the 'Default' hierarchy. They are identical to those found in the 'EN' hierarchy, and serve no useful purpose. (They did once differ, but were made identical in LMS v7.4 - circa 2009). Signed-off-by: Martin Williams <martinr.williams@gmail.com>
Signed-off-by: Michael Herger <michael@herger.net>
…gnore second call! Signed-off-by: Michael Herger <michael@herger.net>
This allows autmatic dev setup in vscode when checking out the repo After checkout, just run `perl slimserverl.pl` to launch the server. For streaming use the webplayer Signed-off-by: LMSSonos <sonos@envamo.com>
…rent branch, else takes latest Signed-off-by: LMSSonos <sonos@envamo.com>
Signed-off-by: LMSSonos <sonos@envamo.com>
…live and not 1.0)" This reverts commit 402261d.
Update Czech translations and correct quotes
# Conflicts: # strings.txt
Signed-off-by: Michael Herger <michael@herger.net>
Signed-off-by: Michael Herger <michael@herger.net>
Signed-off-by: Michael Herger <michael@herger.net>
This change allows remote track metadata comparisons to be done using data from the library, if available, reducing overhead when checking for replay gain or sample rate changes during track transition. Aside from increasing performance, it also eliminates Smart Gain calculation errors caused by the unavailability of remote metadata that has expired from the remote handler's cache, a problem that has plagued the Qobuz plugin. Signed-off-by: Sam Y <syahres@gmail.com>
Signed-off-by: darrell-k <darrell@darrell.org.uk>
Using raw PCM as an intermediary allows seeking on streaming FLACs. When attempting to seek without it, the transcoding command will return an warning that it does "not have accurate sample count available for WAVE header" and fail. The FLAC command has been switched to `--totally-silent` to stop `FLAC__STREAM_DECODER_END_OF_STREAM` messages. LAME outputs the following despite being silenced: ``` WARNING: libsndfile may ignore -r and perform fseek's on the input. Compile without libsndfile if this is a problem. ``` The changes have been tested with the following FLACs: | Description | Sample Rate | Bit Depth | |---------------------------|-------------|-----------| | Local track | 44.1kHz | 16 bit | | Local track | 48.0kHz | 24 bit | | Streaming, Qobuz | 44.1kHz | 16 bit | | Streaming, Qobuz | 96kHz | 24 bit | | Streaming, TIDAL | 44.1kHz | 16 bit | | Streaming, generic Apache | 44.1kHz | 16 bit | Signed-off-by: Jonny Bylsma <jmbylsma@gmail.com>
Embedded cuesheet FLACs require `NOSTART=I` in order to play and be seeked. Without `NOSTART`, the first track of an embedded cuesheet would play, but seeking and subsequent tracks would fail, because only the beginning of the first track would have no offset. Signed-off-by: Jonny Bylsma <jmbylsma@gmail.com>
Signed-off-by: Michael Herger <michael@herger.net>
@darrel-k - could you please confirm I didn't accidentally break the works handling? I don't use them... Signed-off-by: Michael Herger <michael@herger.net>
Signed-off-by: Michael Herger <michael@herger.net>
Update imported actions while we're at it. This needs to be base on 9.0 as we might want to release 9.0.x before 9.1. Signed-off-by: Michael Herger <michael@herger.net>
Signed-off-by: darrell-k <darrell@darrell.org.uk>
Signed-off-by: darrell-k <darrell@darrell.org.uk>
Signed-off-by: darrell-k <darrell@darrell.org.uk>
FTS single track scan
Signed-off-by: Michael Herger <michael@herger.net>
Signed-off-by: Michael Herger <michael@herger.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.