Standardize Lyrion Music Server branding in auth realm and user-agent #1502
Conversation
- Updated strings.txt with LYRION_MUSIC_SERVER token. - Updated Slim/Web/HTTP.pm to use new token for Basic Auth realm. - Updated Slim/Utils/Misc.pm to return 'Lyrion Music Server' as user agent. Signed-off-by: igland <igland@gmail.com>
utsnik
force-pushed
the
feature/lyrion-rebranding
branch
from
8fc3f12 to
01f8d92
Compare
Signed-off-by: Michael Herger <michael@herger.net>
michaelherger
left a comment
michaelherger
left a comment
There was a problem hiding this comment.
Thanks for going through strings again. I change the one occurrence of SqueezeCenter.
How strongly do you feel about the need to add a new string token for the product name? It feels like an unnecessary change to me.
There was a problem hiding this comment.
These changes don't belong in this PR, right?
| ($osDetails->{'osArch'} || 'Unknown'), | ||
| $prefs->get('language'), | ||
| Slim::Utils::Unicode::currentLocale(), | ||
| 'SqueezeCenter, Squeezebox Server, Lyrion Music Server', |
There was a problem hiding this comment.
I'm sorry to say no: some outside systems rely on old UA strings parts. We'd break those integrations with this change. Unfortunately a similar situation as with real browsers, who all still use "Mozilla", or Chrome using "Safari" etc.
| LYRION_MUSIC_SERVER | ||
| EN Lyrion Music Server |
There was a problem hiding this comment.
I don't think this is worth the additional string. Is it confusing to the developer? Maybe. But if a new string, then rather PRODUCT_NAME or similar, so we don't have to change again if needed... And wouldn't we have to update many more uses of the string token?
2 participants
Updated strings.txt with LYRION_MUSIC_SERVER token.
Updated Slim/Web/HTTP.pm to use new token for Basic Auth realm.
Updated Slim/Utils/Misc.pm to return 'Lyrion Music Server' as user agent.