Don't close HTTP when 1.1, unless explicit asked #1460
Merged
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
michaelherger
left a comment
michaelherger
left a comment
There was a problem hiding this comment.
Just saw that you had already pushed this change to 9.1, then reverted? How come?
Contributor
Author
|
The push was a mistake, I was pointing to the slimserver repo directly and I forgot that I have commit rights. So I made a PR as I thought review would be a good idea 😃 |
Member
That's referring to the change from about 8 years ago?... What should I be looking for? How would I experience/test this change? |
Member
|
I think you could have left your change in, I'm going to merge this .Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes I made to close connection on 1.1 was not complete and connection was closing when not needed