Create plugins API and add preprocessor plugin support #888
Conversation
# Conflicts: # packages/server/lib/controllers/spec.coffee # packages/server/lib/socket.coffee # packages/server/lib/util/bundle.coffee # packages/server/test/unit/bundle_spec.coffee # packages/server/test/unit/spec_spec.coffee
|
|
|
@paulfalgout this is the PR for babel configuration and the new plugins API |
| @@ -1 +1 @@ | |||
| {foo: "bar"} | |||
| { 'bar' } | |||
There was a problem hiding this comment.
why such weird javacript string here?
There was a problem hiding this comment.
I'm not sure what that's about. I think eslint keeps auto-formatting it for some reason.
packages/server/lib/config.coffee
Outdated
| videoUploadOnPasses | ||
| watchForFileChanges | ||
| waitForAnimations | ||
| """.trim().split(/\s+/) |
There was a problem hiding this comment.
pretty good idea to have text block here. Maybe separate .trim().split(/\s+/) to named function that describes its purpose like toWords
| @@ -80,10 +106,12 @@ validationRules = { | |||
| integrationFolder: v.isString | |||
| numTestsKeptInMemory: v.isNumber | |||
There was a problem hiding this comment.
we could make these predicates stronger by having method v.isPositive to make sure user provided value is > 0
There was a problem hiding this comment.
Sounds good to me. Seems out of scope for this PR though...
packages/socket/test/socket_spec.js
Outdated
| it('returns client source as a string', function(done) { | ||
| const p = process.cwd() + '/node_modules/socket.io-client/dist/socket.io.js' | ||
| it('returns client source as a string', function (done) { | ||
| const p = `${process.cwd()}/node_modules/socket.io-client/dist/socket.io.js` |
There was a problem hiding this comment.
I think we should be more consistent about using path.join here
There was a problem hiding this comment.
Agreed. I think the only reason this changed is that eslint auto-fixed it.
- tested locally
|
Fixes #684 |
Implements the base plugins API and preprocessor plugin support as per #684.
Related PRs:
Docs: cypress-io/cypress-documentation#226
Examples: cypress-io/cypress-example-recipes#19