-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide an option to disable test files preprocessing. #533
Comments
Any plan on making this possible? ClojureScript has a mature (6+ years), large, enthusiastic community without a lot of robust available options in the integration-testing space. cypress could fill that gap! @kamituel , could you get this to work? |
selenium-java :)
Nope. For now I settled on using JavaScript basically. However, I'm using Cypress to test a proof-of-concept project we're working on. If we were to start using Cypress for our main web app, ClojureScript support would be necessary. I discussed it briefly with Cypress' team on Gitter a while back and they weren't opposed to this idea. It's probably just not high on a priority list. Having that said, Cypress |
We're currently working on a generic plugin system for preprocessing spec files that will solve this issue. You'll be able to create a plugin that integrates with the Cypress preprocessing pipeline. It will allow you to disable the default preprocessing, or you could create a ClojureScript preprocessor that transpiles your ClojureScript tests and lets the app know to re-run. This should be released within the next month or so. If it doesn't make it into |
Sounding awesome! Good luck with the development and release of Cypress! Cheers - Victor |
@chrisbreiding |
Fixed by #888. |
Fixed in |
With the plugins API now released, you can create a ClojureScript preprocessor or you can essentially disable preprocessing by using the watch preprocessor. |
Are you requesting a feature or reporting a bug?
Feature.
Current behavior:
Cypress preprocesses test JavaScript files (using Babel / Browserify). I'd like to use ClojureScript to write tests, which means using a compiler (based on Google Closure) to obtain a final test JS file. However, Google Closure produces JS files that expect
this
to be set when invoked outside of a function (in the global context). Current Cypress' preprocessing makesthis
undefined
, which breaks code compiled using Google Closure. I don't know of any obvious workaround for this.Expected behavior:
To be able to disable test JS files preprocessing, so that I can use ClojureScript / Google Closure compiler.
How to reproduce the current behavior:
Compile it using ClojureScript compiler to
cypress/integration/test.js
Run this test using Cypress. It will hang for a long time, and eventually produce an error that can be tracked down to
this
being unset.Test code:
n/a
Additional Info (images, notes, stack traces, etc)
This has been briefly discussed on Gitter on June 9th around 1:30 PM UTC.
The text was updated successfully, but these errors were encountered: