-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create plugins API and add preprocessor plugin support #888
Merged
Merged
Changes from 73 commits
Commits
Show all changes
82 commits
Select commit
Hold shift + click to select a range
36eacaa
fix broken menu specs
chrisbreiding b8a820c
extract browserify code and create preprocessor abstraction
chrisbreiding 73d794f
Merge branch 'master' into preprocessor-refactor
chrisbreiding 058ac46
Merge branch 'develop' into preprocessor-refactor
chrisbreiding e25c924
Merge branch 'develop' into preprocessor-refactor
chrisbreiding 694caa0
server: remove unused code
chrisbreiding f42ee15
server: implement logic for importing preprocessor
chrisbreiding 62e07db
Merge branch 'develop' into preprocessor-refactor
chrisbreiding 8d38995
Merge branch 'develop' into preprocessor-refactor
chrisbreiding 3f91b51
server: add eslintrc and ignore test fixtures
chrisbreiding 00c0444
server: implement plugins API
chrisbreiding 8cc7633
Merge branch 'develop' into preprocessor-refactor
chrisbreiding c766657
server: add node_cache module to manage clearing a package and its de…
chrisbreiding 0a01d24
server: clear plugins file from cache to re-require it
chrisbreiding 1184a07
server: set pluginsFile to absolute path
chrisbreiding 48d0916
server: add debug logging to plugins
chrisbreiding 723cdcc
server: watch pluginsFile
chrisbreiding 92945c4
server: throw the right error when requiring plugins file
chrisbreiding 8ea4f34
server: organize config folders and keys visually
chrisbreiding 64eeccb
server: scaffold plugins file
chrisbreiding 2a533a0
server: require plugins file via nodeCache.require
chrisbreiding 184baa7
Merge branch 'develop' into preprocessor-refactor
chrisbreiding 854d968
Merge branch 'develop' into preprocessor-refactor
chrisbreiding b7ff32e
server: update browserify preprocessor name and point to github for now
chrisbreiding b8b556c
server: remove redundant integration tests
chrisbreiding 7bb6145
server: always scaffold plugins file, except when falsey
chrisbreiding 7d35576
server: add plugins file test to scaffold spec
chrisbreiding b53fe5f
server: always provide util.fileUpdated to preprocessor
chrisbreiding 9a536e4
server: update browserify-preprocessor dep
chrisbreiding e9059a3
server: fix integration tests
chrisbreiding 37f0bde
server: remove redundant logic
chrisbreiding 240e736
server: catch errors thrown synchronously by plugins function
chrisbreiding e11a23f
Merge branch 'develop' into preprocessor-refactor
chrisbreiding 37522bc
server: reduce chances of flakyness in async test
chrisbreiding 3137e0f
driver: fix broken spec
chrisbreiding 2052fc7
server: don’t check for dirname of supportFile and pluginFile when we…
chrisbreiding 7e56623
Merge branch 'develop' into preprocessor-refactor
chrisbreiding ca63cb0
driver: there is no dist
chrisbreiding a5efb92
server: update default options sent to browserify preprocessor
chrisbreiding eaa1b6d
server: send config into browserify instead of options
chrisbreiding 5b71c84
server: add test around default preprocessor
chrisbreiding 048bd29
Merge branch 'develop' into preprocessor-refactor
chrisbreiding 31f43ea
Merge branch 'develop' into preprocessor-refactor
chrisbreiding 8fb7348
server: update browserify preprocessor
chrisbreiding 2d8ee05
server: refactor events spec to better handle multiple calls to handl…
chrisbreiding 6ff3dc2
server: add tests around project:open events
chrisbreiding 5c7fe76
server/desktop-gui: handle errors when plugins file changes
chrisbreiding 46a9b34
Merge branch 'develop' into preprocessor-refactor
chrisbreiding d371549
Merge branch 'develop' into preprocessor-refactor
chrisbreiding 60666be
Merge branch 'develop' into preprocessor-refactor
chrisbreiding d781ce8
server: fix events spec
chrisbreiding 146996c
server: allow any file types to be spec files
chrisbreiding 5ef8f52
Merge branch 'develop' into preprocessor-refactor
chrisbreiding 3a745d9
server: validate config.pluginsFile
chrisbreiding 941e881
server: remove link to error doc
chrisbreiding e0f13cb
server: improve plugins error message
chrisbreiding 280a880
server: simplify example plugins file
chrisbreiding f352801
server: on:spec:file:preprocessor -> file:preprocessor
chrisbreiding 6aef011
server: wrap plugins in a child process
chrisbreiding 82f4d53
server: rename specsGlob to testFiles
chrisbreiding e2f56c7
Merge branch 'develop' into preprocessor-refactor
chrisbreiding e7b39b1
server: bump browserify-preprocessor ‘version’
chrisbreiding 8458401
Merge branch 'develop' into preprocessor-refactor
chrisbreiding 4d4f32d
server: fix references left by merge
chrisbreiding a9dcf78
server: fix incorrect function names
chrisbreiding 7299e4e
server: fix plugin error serialization
chrisbreiding 701401f
server: display error if plugins process has an uncaught exception or…
chrisbreiding ad41441
server: reset domain on reset
chrisbreiding 2a16813
server: exit early on plugin error headlessly
chrisbreiding db46c14
server: add e2e tests for plugins/preprocessors
chrisbreiding 479b34f
server: remove obselete node cache file
chrisbreiding e291d67
server: fix integration tests
chrisbreiding 8e51a7f
server: log plugins error before exiting
chrisbreiding eafee68
server: use npm version of browserify preprocessor
chrisbreiding 2c7b670
server: extract string-splitting function
chrisbreiding 1fd8873
socket: use path.join in spec
chrisbreiding f8e7ae7
Merge branch 'develop' into preprocessor-refactor
chrisbreiding 5f95a21
Merge branch 'develop' into preprocessor-refactor
bahmutov b9d86ab
server: eslint ignore scaffold files
brian-mann ff644de
server: fix scaffolded plugins file links, add snapshot test
brian-mann 39c0bcb
server: if app_spec runs, cause a failure [skip ci]
brian-mann 7fa4033
Merge branch 'develop' into preprocessor-refactor
brian-mann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
{ | ||
"projectId": "fas5qd", | ||
"pluginsFile": false, | ||
"viewportWidth": 800, | ||
"viewportHeight": 550 | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
{foo: "bar"} | ||
{ 'bar' } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why such weird javacript string here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what that's about. I think eslint keeps auto-formatting it for some reason.