Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow typing into readonly fields. #4729

Merged
merged 4 commits into from
Jul 18, 2019
Merged

Conversation

jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane requested a review from a team July 16, 2019 10:14
@jennifer-shehane jennifer-shehane merged commit fcabf50 into develop Jul 18, 2019
@cypress-bot cypress-bot bot mentioned this pull request Jul 18, 2019
@jennifer-shehane jennifer-shehane deleted the issue-1246 branch July 18, 2019 07:59
@brian-mann
Copy link
Member

brian-mann commented Jul 22, 2019

This implementation won't work correctly.

This logic needs to be retry-able - and needs to go within the actionability files, not in cy.type. If you look closely you'll notice that other logic (like disabled inputs) is not in the cy.type implementation for this reason.

The only validation you should do up front are for immutable properties - such as passing invalid arguments to cy.type(...). In those cases, we cannot retry and therefore fail fast and early.

You should review the other cy.type() specs that handle inputs that are hidden, or disabled so you can understand how this should be written.

This PR needs to be reverted until the implementation is fixed - this will otherwise cause spurious failures since the DOM is mutable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate readonly fields
3 participants