You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an edit webhook subscription page that should enable the following fields to update: subscriptionId, EventKey, Severity, CallbackURL, Status.
Add one cypress test to test that the new edit page works as expected and updates the appropriate fields.
Reviewer Notes
When writing my test I noticed that the test associated with the create page isn't working. I updated the tests so that they are now passing. A second pair of eyes on these fixes are appreciated.
Setup
To check the new page exists run make server_run and make admin_client_run. Do a local sign-in and then select an existing admin-user to log in. Go to the WebhookSubscription tab and click on one subscription. Then click on "Edit" in the top right hand corner to inspect the Edit page.
To run the tests: yarn test:e2e. Then select the "Webhook Subscription" file in the cypress browser. You should be directed to the tests for all Webhook Subscription pages.
It looks like you are attempting to bypass a linter rule, which is not within
security compliance rules.
** Contains a rule that is not in the permitted eslint list. You are free to disable only: (
no-underscore-dangle
,prefer-object-spread
,object-shorthand
,camelcase
,react/jsx-props-no-spreading
,react/destructuring-assignment
,react/forbid-prop-types
,react/prefer-stateless-function
,react/sort-comp
,import/no-extraneous-dependencies
,import/order
,import/prefer-default-export
,import/no-named-as-default
) **
Please remove the bypass code and address the underlying issue. cc: @transcom/Truss-Pamplemoose
⚠️
This PR does not include changes to unit tests, even though it affects app code.
⚠️
Files located in legacy directories (src/shared or src/scenes) have
been edited. Are you sure you don’t want to also relocate them to the new file structure?
The reason will be displayed to describe this comment to others. Learn more.
Hmm, was reading through this old cypress PR, I think that depends if the field has hidden or disabled inputs? I was looking at using .type() to check readonly fields.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add an edit webhook subscription page that should enable the following fields to update: subscriptionId, EventKey, Severity, CallbackURL, Status.
Add one cypress test to test that the new edit page works as expected and updates the appropriate fields.
Reviewer Notes
When writing my test I noticed that the test associated with the create page isn't working. I updated the tests so that they are now passing. A second pair of eyes on these fixes are appreciated.
Setup
To check the new page exists run
make server_runandmake admin_client_run. Do alocal sign-inand then select an existing admin-user to log in. Go to the WebhookSubscription tab and click on one subscription. Then click on "Edit" in the top right hand corner to inspect the Edit page.To run the tests:
yarn test:e2e. Then select the "Webhook Subscription" file in the cypress browser. You should be directed to the tests for all Webhook Subscription pages.References