Refactor readonly input typing #4783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jennifer-shehane
commented
Jul 23, 2019
•
jennifer-shehane
commented
- close Do not allow typing into readonly fields. #4729 - refactor of comments made there
- add validation to check for readonly attr on retry of type as per w3.org/TR/2010/WD-html5-20101019/common-input-element-attributes.html#attr-input-readonly
- close Validate readonly fields #1246
brian-mann
approved these changes
Jul 23, 2019
|
This seem to be blocking other events and not only |
|
@gabrieldutra This should only affect typing, so not being able to click would be a regression. Can you open a new issue please with the html and test code to reproduce this? |
|
OPened an issue here #4874 |
|
You were faster than me 😁. Thanks for the answer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.