Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency: upgrade to electron 29 #30224

Open
wants to merge 66 commits into
base: develop
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
66 commits
Select commit Hold shift + click to select a range
121aef3
bump Electron/node/node-abi + run extra workflows in CI
jennifer-shehane Feb 16, 2024
a74681e
empty commit
jennifer-shehane Feb 16, 2024
6e73a3e
bump docker images to node + chrome versions for Electron 28
jennifer-shehane Feb 20, 2024
05f873d
bump node types
jennifer-shehane Feb 20, 2024
1cbd4ea
bump xcode to version with default Node v18.17.1
jennifer-shehane Feb 20, 2024
fe34d4d
Merge branch 'develop' into electron-28
jennifer-shehane Feb 20, 2024
837a079
Bump types/node
jennifer-shehane Feb 20, 2024
23cbb71
Merge branch 'electron-28' of https://github.com/cypress-io/cypress i…
jennifer-shehane Feb 20, 2024
652eeaa
update getFileName to follow types of string or undefined
jennifer-shehane Feb 20, 2024
0d3bae1
ts-ignore fetch spread
jennifer-shehane Feb 21, 2024
8e66ac2
yarn lock update
jennifer-shehane Feb 21, 2024
2ef87a0
bump system test yarn lock
jennifer-shehane Feb 21, 2024
3b9c2d9
yarn/types node bump
jennifer-shehane Feb 22, 2024
de8ab30
fix types definition for node types
jennifer-shehane Feb 22, 2024
306e5b6
Merge branch 'develop' into electron-28
jennifer-shehane Feb 22, 2024
5f40d20
Merge branch 'develop' into electron-28
jennifer-shehane Mar 5, 2024
1401928
Merge branch 'develop' into electron-28
jennifer-shehane Mar 7, 2024
1113a99
Merge branch 'develop' of github.com:cypress-io/cypress into electron-28
AtofStryker May 15, 2024
ef36f34
empty commit to run ci [run ci]
AtofStryker May 15, 2024
763367a
fix merge conflict because vscode is really slow to save files with h…
AtofStryker May 15, 2024
1fbc23c
empty commit to run ci [run ci]
AtofStryker May 15, 2024
2a6d6e2
print original toString for fs temporarily to swap value [run ci]
AtofStryker May 15, 2024
decdca0
fix typing issues
AtofStryker May 15, 2024
99d1620
update integrity check [run ci]
AtofStryker May 15, 2024
52addeb
fix stack integrity check
AtofStryker May 15, 2024
500225b
use 18.20.2 docker image [run ci]
AtofStryker May 15, 2024
de6a1fd
Update binary-integrity-check-source.js
ryanthemanuel May 15, 2024
e858554
Update smoke.js
ryanthemanuel May 15, 2024
9985f75
update trigger binary publish and bump cache [run ci]
AtofStryker May 15, 2024
67c4065
Merge branch 'electron-28' of github.com:cypress-io/cypress into elec…
AtofStryker May 15, 2024
ef8361c
bump cache [run ci]
AtofStryker May 15, 2024
a32c241
fix issues with browser window sending cross origin requests as the w…
AtofStryker May 15, 2024
9595366
update docker images [run ci]
AtofStryker May 16, 2024
a5d92ae
Merge branch 'develop' into electron-28
AtofStryker May 16, 2024
f871559
add changelog entry
AtofStryker May 16, 2024
aa36916
update to latest electron 28
AtofStryker May 16, 2024
b0276b6
Merge branch 'electron-28' of github.com:cypress-io/cypress into elec…
AtofStryker May 16, 2024
c5c44af
fix error in changelog
AtofStryker May 16, 2024
0d14d87
fix snapshots in firefox with firefox 126 update
AtofStryker May 16, 2024
1549bd2
Merge branch 'electron-28' of github.com:cypress-io/cypress into elec…
AtofStryker May 16, 2024
208bc8b
polish firefox system tests for somewhat hacky work around
AtofStryker May 16, 2024
55287d4
update cy-non-proxied image to fit base64 encoding in test
AtofStryker May 16, 2024
8286d7b
empty commit to trigger ci [run ci]
AtofStryker May 17, 2024
f56bb33
Merge branch 'develop' into electron-28
jennifer-shehane May 21, 2024
a589f05
Merge branch 'develop' into electron-28
jennifer-shehane May 21, 2024
b52aef9
WIP
AtofStryker May 24, 2024
94a69ec
fix
ryanthemanuel Sep 11, 2024
a0ec796
merge develop
ryanthemanuel Sep 11, 2024
ac4fc2b
Bump to 29.4.6
jennifer-shehane Sep 11, 2024
01023e0
Update scripts/binary/trigger-publish-binary-pipeline.js
jennifer-shehane Sep 11, 2024
4255fb5
add code comment for why --no-use-ic flag is there
jennifer-shehane Sep 11, 2024
9f31f09
Merge branch 'electron-29' of https://github.com/cypress-io/cypress i…
jennifer-shehane Sep 11, 2024
ee67e7b
remove 'empty' visits to ensure 29 works without these changes.
jennifer-shehane Sep 11, 2024
2bce45f
try to downgrade better-sqlite
jennifer-shehane Sep 11, 2024
44c070d
better-sqlite3 10
ryanthemanuel Sep 11, 2024
9fe813a
fix build
ryanthemanuel Sep 11, 2024
ba370fc
fix
ryanthemanuel Sep 11, 2024
a50043e
ensure that the branch gets used in the publish step
ryanthemanuel Sep 11, 2024
01bdddc
turn off auto-cancellation for these runs to see what's failing
jennifer-shehane Sep 12, 2024
beea4b7
Update scripts/binary/trigger-publish-binary-pipeline.js
ryanthemanuel Sep 12, 2024
cad44d8
fix types error
ryanthemanuel Sep 12, 2024
2e8876e
remove gcc
ryanthemanuel Sep 12, 2024
0ae94b2
try something
ryanthemanuel Sep 12, 2024
f03ad63
try something else
ryanthemanuel Sep 12, 2024
4f849dd
bump Node.js to 20
jennifer-shehane Sep 13, 2024
610ea3b
Merge branch 'electron-29' of https://github.com/cypress-io/cypress i…
jennifer-shehane Sep 13, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove gcc
  • Loading branch information
ryanthemanuel committed Sep 12, 2024
commit 2e8876e90422b3034d9f748c4ce4e7e498372d8f
2 changes: 1 addition & 1 deletion .circleci/workflows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -531,7 +531,7 @@ commands:
apt update && apt install -y docker.io
docker run -d --name centos7-builder cypress/centos7-builder:latest /bin/bash -c "sleep 1000000000"
docker cp ~/cypress/node_modules/better-sqlite3 centos7-builder:/better-sqlite3
docker exec -it centos7-builder /bin/bash -c "yum install -y wget && yum install -y gcc openssl-devel bzip2-devel libffi-devel zlib-devel && wget https://www.python.org/ftp/python/3.8.0/Python-3.8.0.tgz && tar xvf Python-3.8.0.tgz && cd Python-3.8.0 && ./configure --enable-optimizations --prefix=/usr && make altinstall && rm /usr/bin/python3 && ln -s /usr/bin/python3.8 /usr/bin/python3 && cd ../better-sqlite3 && source /root/.bashrc && chown -R root:root . && npm install --ignore-scripts && npx --no-install prebuild -r electron -t 29.4.6 --include-regex 'better_sqlite3.node$'"
docker exec -it centos7-builder /bin/bash -c "yum install -y wget && yum install -y openssl-devel bzip2-devel libffi-devel zlib-devel && wget https://www.python.org/ftp/python/3.8.0/Python-3.8.0.tgz && tar xvf Python-3.8.0.tgz && cd Python-3.8.0 && ./configure --enable-optimizations --prefix=/usr && make altinstall && rm /usr/bin/python3 && ln -s /usr/bin/python3.8 /usr/bin/python3 && cd ../better-sqlite3 && source /root/.bashrc && chown -R root:root . && npm install --ignore-scripts && npx --no-install prebuild -r electron -t 29.4.6 --include-regex 'better_sqlite3.node$'"
docker cp centos7-builder:/better-sqlite3/build/Release/better_sqlite3.node ~/cypress/node_modules/better-sqlite3/build/Release/better_sqlite3.node
docker rm -f centos7-builder
cp ~/cypress/node_modules/better-sqlite3/build/Release/better_sqlite3.node ~/cypress/better_sqlite3.node
Expand Down
Loading