-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dependency: upgrade to electron 29 #30224
Closed
Closed
Changes from 1 commit
Commits
Show all changes
66 commits
Select commit
Hold shift + click to select a range
121aef3
bump Electron/node/node-abi + run extra workflows in CI
jennifer-shehane a74681e
empty commit
jennifer-shehane 6e73a3e
bump docker images to node + chrome versions for Electron 28
jennifer-shehane 05f873d
bump node types
jennifer-shehane 1cbd4ea
bump xcode to version with default Node v18.17.1
jennifer-shehane fe34d4d
Merge branch 'develop' into electron-28
jennifer-shehane 837a079
Bump types/node
jennifer-shehane 23cbb71
Merge branch 'electron-28' of https://github.com/cypress-io/cypress i…
jennifer-shehane 652eeaa
update getFileName to follow types of string or undefined
jennifer-shehane 0d3bae1
ts-ignore fetch spread
jennifer-shehane 8e66ac2
yarn lock update
jennifer-shehane 2ef87a0
bump system test yarn lock
jennifer-shehane 3b9c2d9
yarn/types node bump
jennifer-shehane de8ab30
fix types definition for node types
jennifer-shehane 306e5b6
Merge branch 'develop' into electron-28
jennifer-shehane 5f40d20
Merge branch 'develop' into electron-28
jennifer-shehane 1401928
Merge branch 'develop' into electron-28
jennifer-shehane 1113a99
Merge branch 'develop' of github.com:cypress-io/cypress into electron-28
AtofStryker ef36f34
empty commit to run ci [run ci]
AtofStryker 763367a
fix merge conflict because vscode is really slow to save files with h…
AtofStryker 1fbc23c
empty commit to run ci [run ci]
AtofStryker 2a6d6e2
print original toString for fs temporarily to swap value [run ci]
AtofStryker decdca0
fix typing issues
AtofStryker 99d1620
update integrity check [run ci]
AtofStryker 52addeb
fix stack integrity check
AtofStryker 500225b
use 18.20.2 docker image [run ci]
AtofStryker de6a1fd
Update binary-integrity-check-source.js
ryanthemanuel e858554
Update smoke.js
ryanthemanuel 9985f75
update trigger binary publish and bump cache [run ci]
AtofStryker 67c4065
Merge branch 'electron-28' of github.com:cypress-io/cypress into elec…
AtofStryker ef8361c
bump cache [run ci]
AtofStryker a32c241
fix issues with browser window sending cross origin requests as the w…
AtofStryker 9595366
update docker images [run ci]
AtofStryker a5d92ae
Merge branch 'develop' into electron-28
AtofStryker f871559
add changelog entry
AtofStryker aa36916
update to latest electron 28
AtofStryker b0276b6
Merge branch 'electron-28' of github.com:cypress-io/cypress into elec…
AtofStryker c5c44af
fix error in changelog
AtofStryker 0d14d87
fix snapshots in firefox with firefox 126 update
AtofStryker 1549bd2
Merge branch 'electron-28' of github.com:cypress-io/cypress into elec…
AtofStryker 208bc8b
polish firefox system tests for somewhat hacky work around
AtofStryker 55287d4
update cy-non-proxied image to fit base64 encoding in test
AtofStryker 8286d7b
empty commit to trigger ci [run ci]
AtofStryker f56bb33
Merge branch 'develop' into electron-28
jennifer-shehane a589f05
Merge branch 'develop' into electron-28
jennifer-shehane b52aef9
WIP
AtofStryker 94a69ec
fix
ryanthemanuel a0ec796
merge develop
ryanthemanuel ac4fc2b
Bump to 29.4.6
jennifer-shehane 01023e0
Update scripts/binary/trigger-publish-binary-pipeline.js
jennifer-shehane 4255fb5
add code comment for why --no-use-ic flag is there
jennifer-shehane 9f31f09
Merge branch 'electron-29' of https://github.com/cypress-io/cypress i…
jennifer-shehane ee67e7b
remove 'empty' visits to ensure 29 works without these changes.
jennifer-shehane 2bce45f
try to downgrade better-sqlite
jennifer-shehane 44c070d
better-sqlite3 10
ryanthemanuel 9fe813a
fix build
ryanthemanuel ba370fc
fix
ryanthemanuel a50043e
ensure that the branch gets used in the publish step
ryanthemanuel 01bdddc
turn off auto-cancellation for these runs to see what's failing
jennifer-shehane beea4b7
Update scripts/binary/trigger-publish-binary-pipeline.js
ryanthemanuel cad44d8
fix types error
ryanthemanuel 2e8876e
remove gcc
ryanthemanuel 0ae94b2
try something
ryanthemanuel f03ad63
try something else
ryanthemanuel 4f849dd
bump Node.js to 20
jennifer-shehane 610ea3b
Merge branch 'electron-29' of https://github.com/cypress-io/cypress i…
jennifer-shehane File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
ts-ignore fetch spread
- Loading branch information
commit 0d3bae1e97850c852e18ac0b0a805edec51d350f
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To address error below. Open to better ideas here. https://app.circleci.com/pipelines/github/cypress-io/cypress/59948/workflows/efa9b4b3-12ca-4f83-a8d7-d5c9186f28d4/jobs/2493976