dependency: upgrade to electron 29 #30224
Conversation
…nto electron-28
…ooks running [run ci]
| @@ -16,7 +16,7 @@ | |||
| "types": [ | |||
| "cypress", | |||
| "./support", | |||
| "./node_modules/@types/node" | |||
| "node" | |||
There was a problem hiding this comment.
| @@ -181,6 +181,7 @@ export class DataContext { | |||
| @cached | |||
| get cloud () { | |||
| return new CloudDataSource({ | |||
| // @ts-ignore | |||
There was a problem hiding this comment.
To address error below. Open to better ideas here. https://app.circleci.com/pipelines/github/cypress-io/cypress/59948/workflows/efa9b4b3-12ca-4f83-a8d7-d5c9186f28d4/jobs/2493976
| @@ -26,6 +26,7 @@ describe('network stubbing', { retries: 15 }, function () { | |||
|
|
|||
| beforeEach(function () { | |||
| cy.spy(Cypress.utils, 'warning') | |||
| cy.visit('/fixtures/empty.html') | |||
There was a problem hiding this comment.
We'll want to remove this. This should have only been necessary in Electron 28 - that's the assumption anyway. See https://github.com/cypress-io/cypress/pull/28959/files#r1603224984
| @@ -39,7 +39,7 @@ | |||
| "ansi_up": "5.0.0", | |||
| "ast-types": "0.13.3", | |||
| "base64url": "^3.0.1", | |||
| "better-sqlite3": "9.2.2", | |||
| "better-sqlite3": "10.0.0", | |||
There was a problem hiding this comment.
@ryanthemanuel Do you remember the context as to why this was necessary?
There was a problem hiding this comment.
I do not unfortunately. We can try reverting?
There was a problem hiding this comment.
@AtofStryker do you happen to remember either? I know you were working in here too at times.
There was a problem hiding this comment.
I was just wondering - I don't think have confirmation that it's breaking anything - it was just a difference between 29 and 28
There was a problem hiding this comment.
This is needed due to this failure when it is left on 9.2.2: https://cloud.nx.app/runs/n23a1Mbn3x
| @@ -462,7 +462,7 @@ export class SnapshotGenerator { | |||
|
|
|||
| // 2. Run the `mksnapshot` binary providing it the path to our snapshot | |||
| // script | |||
| const args = [this.snapshotScriptPath, '--output_dir', this.snapshotBinDir] | |||
| const args = [this.snapshotScriptPath, '--output_dir', this.snapshotBinDir, '--no-use-ic'] | |||
There was a problem hiding this comment.
See https://issues.chromium.org/issues/345280736#comment12 for context - we should add this inline as a comment.
cypress
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
electron-29
|
| Run status |
|
| Run duration | 18m 24s |
| Commit |
|
| Committer | Ryan Manuel |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
2
|
Flaky
|
2
|
Pending
|
26
|
Skipped
|
0
|
Passing
|
768
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
67.9%
|
|
|---|---|
|
Untested elements
|
24
|
|
Tested elements
|
55
|
Accessibility
96.4%
|
|
|---|---|
|
Failed rules
|
0 critical
6 serious
1 moderate
0 minor
|
|
Failed elements
|
210
|
Tests for review
cypress\e2e\config-files-error-handling.cy.ts • 1 failed test • launchpad-e2e
| Test | Artifacts | |
|---|---|---|
| Launchpad: Error System Tests > shows correct stack trace when config with ts-module error |
Test Replay
Screenshots
|
|
cypress\e2e\runner\retries.experimentalRetries.mochaEvents.cy.ts • 1 failed test • app-e2e
| Test | Artifacts | |
|---|---|---|
| ... > does not try to serialize error with err.actual as DOM node |
Test Replay
Screenshots
|
|
cypress\e2e\specs.cy.ts • 1 flaky test • app-e2e
| Test | Artifacts | |
|---|---|---|
| ... > scaffold starter spec > generates spec with file name that does not contain a known spec extension |
Test Replay
Screenshots
|
|
cypress\e2e\subscriptions\createCloudOrgModal-subscription.cy.ts • 1 flaky test • app-e2e
| Test | Artifacts | |
|---|---|---|
| CreateCloudOrgModalSubscription > Runs - Connect Org > opens create Org modal after clicking Connect Project button |
Test Replay
Screenshots
|
|
jennifer-shehane
changed the title
| @@ -185,7 +185,7 @@ export function create (projectRoot, _options: WindowOptions, newBrowserWindow = | |||
| }) | |||
| } | |||
|
|
|||
| win.webContents.on('crashed', function (...args) { | |||
| win.webContents.on('render-process-gone', function (...args) { | |||
There was a problem hiding this comment.
Addresses this type failure: https://cloud.nx.app/runs/cibLuMvwic
This event was removed in 29: https://github.com/electron/electron/pull/40115/files#diff-18ed6a5b5a9084c976509502962b7f05989a8bd13a2ba3dc02868056938c03b6
CHANGELOG - https://releases.electronjs.org/releases/stable?version=29
Additional details
Related Docker Images PR https://github.com/cypress-io/cypress-docker-images/pull/1052/files
Unfortunately there is a breaking change in Electron 28 that would affect our users. That breaking change has been fixed in Electron 29, but Electron 29 contains a bug in v8 that we've had to raise with Chromium here: issues.chromium.org/issues/345280736 We're awaiting to see what their response is as we need a resolution to continue our upgrade.
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?