Add error reporting for broken images #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids problems with chrome extensions and similar browser interference. This is necessary now with closure compiler because it does not keep module functions in tact. Adds a regression test for not leaking global symbols. Fixes ampproject#1679
Properly wrap our main binary in a IEFE.
amp-embed now validates.
Validator roll-up
Avoid promise rejection before storage API is actually used
… browsers. MSIE is pretty close, but still has a few failures. iPhone continues to time out. Maybe we should make 2 super simple tests for them, just for sanity. Related to ampproject#895
Otherwise it is e.g. hard to know when one can reload an example page and get new JS.
Get tests in saucelabs passing again and add MS Edge to set of tested browsers.
Output message when all current browserify bundle operations are done.
# The first commit's message is: Adding type='comscore' to <amp-analytics>. # The 2nd commit message will be skipped: # Adding comScore example pageview tracking
Adds support for comScore
update lint versions, downgrade escope manually
Validation roll-up
remove escope and upgrade eslint-babel
Documentation for heights attribute
Customize return URL query form
add release for branches to build on push
Whitelist embed types that are allowed to use amp-embed.
Add documentation for integrating an analytics service
Add support for Parsely analytics
1. Allow clearInterval from a different window to clear an interval 2. Allow string args to setInterval 3. Make clearInterval also clear non-instrumented intervals.
Fix 3 bugs in environment instrumentation
…-flake Fix Flakey Travis Dyanmic-CSS-Classes
Call eval with correct context.
Launch amp-access
Allow prerendering amp-video poster
Fix flaky timer test by using a mock clock.
Strong recommendation to return the actual origin in the Access-Control-Allow-Origin
1. Send messages encoded as JSON. This is faster than the algorithm that is mandated by the spec for objects. 2. Only parse a response once and do the listener dispatch in user land. 3. Call stopImmediatePropagation on our messages, so others don't have to loop at them.
Launch amp-storage experiment
3 signficant speedups for iframe communication
add missing pre-connect urls for taboola
feature(perf): add `setParams` method
cramforce
pushed a commit
that referenced
this pull request
Sep 14, 2019
* Merge to local master (#1) SmileWanted new ad code support * Merge to local master ampproject#2 * SmileWanted new ad code support 1st version of SmileWanted ad code support * fix lint errors
cramforce
pushed a commit
that referenced
this pull request
Jun 6, 2020
* [ADOCEAN-20673] remove livepreview1 * fix lint error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ampproject#1529