amp-brightcove - pass custom params and allow data-player

[mister-ben]

A few updates to amp-brightcove

• Some publishers need to pass custom parameters through to plugins specific to their players, e.g. article-specific values that need to be included in ad tags. All data-param-* attributes will now be passed camel cased in the query string of the player iframe src, in line with Append data-param-* attributes to amp-iframe src as query params. #1537
• Documentation for data-param-*
• Tests for data-param-*
• amp-brightcove uses data-player-id as an attribute whereas the standard non-AMP embed for the Brightcove Player uses data-player. data-player had been intended, hence the confusion in the docs (Brightcove player attribute #1793). Since publishers may well assume the same attribute as the non-AMP embed, amp-brightcove now supports either.
• Docs and examples have been updated to standardise on data-player but note the compatibility with data-player-id

[dvoytenko]

/cc @Gregable @powdercloud on any possible validator needs.

[cramforce]

LGTM. Test errors seem unrelated. This should not affect validation.

Please squash the commits and this is good to go.

[mister-ben]

Squashed. Thanks.

[jridgewell]

Reverted in #1924 due to (seemingly unrelated) test failures. I'll be investigating today.

[mister-ben]

It's beyond me why they're failing. Sorry for causing trouble.

[mstoltenburg]

Maybe https://github.com/ampproject/amphtml/blob/master/validator/validator.protoascii#L2212 should be changed to check for data-player-id again? Because that is used by the examples…

[Gregable]

Following up on this thread to make sure we're validating amp-brightcove correctly. The current rules are:
data-account - mandatory, all values allowed
data-* - optional, all values allowed
Allowed layouts: fixed, fixed_height, responsive, fill, nodisplay.

In order to help publishers find bugs, It looks like we may also want to:

• require one of data-player or data-player-id, possibly with a deprecation warning for the latter?
• require "default", any shortid, or any GUID for the value of data-embed, if attribute is set. What is the format of a shortid?
• require "default" or any GUID for the value of data-embed, if attribute is set.

Thoughts?