-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Revert "Merge pull request #1909 from BrightcoveOS/amp-brightcove-params"" #1946
Conversation
9853429
to
0efb95d
Compare
Is this an experiment? I thought the |
@mstoltenburg really sorry, we had to roll this back as it was causing our builds to fail. will try and get this back in as soon as possible. possibly just skipping the test for now until we figure it out. |
9ccc226
to
d8d4d23
Compare
@cramforce only change i did was the 2nd commit skipping the last test. |
d8d4d23
to
eed7b41
Compare
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
@mister-ben can you please respond to the google bot with "I confirm", i cherry picked your commit again to give you proper attribution (so that it is your commit). i had to skip the last test to make travis green. |
@googlebot i confirm |
@mstoltenburg I'm very sorry about the changing from |
LGTM |
Ping @erwinmombay: Are we merging this back in? |
Allow `data-player` as intented as well as `data-playerid` Use `data-player` in docs Document `data-param-*`
eed7b41
to
b0336a1
Compare
@jridgewell yep, just waiting on green build again |
Revert "Revert "Merge pull request #1909 from BrightcoveOS/amp-brightcove-params""
This reverts commit e5ab3f5.