Revert "Revert "Merge pull request #1909 from BrightcoveOS/amp-brightcove-params""

[erwinmombay]

This reverts commit e5ab3f5.

[mstoltenburg]

Is this an experiment? I thought the data-player attribute finally changed to data-player-id. Though the normal (not AMP) brightcove player embed code uses data-player. And there is still one occurrence/check for data-player inside validator.protoascii in master.

[erwinmombay]

@mstoltenburg really sorry, we had to roll this back as it was causing our builds to fail. will try and get this back in as soon as possible. possibly just skipping the test for now until we figure it out.

[erwinmombay]

@cramforce only change i did was the 2nd commit skipping the last test.

[googlebot]

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

[erwinmombay]

@mister-ben can you please respond to the google bot with "I confirm", i cherry picked your commit again to give you proper attribution (so that it is your commit). i had to skip the last test to make travis green.

[mister-ben]

@googlebot i confirm

[mister-ben]

@mstoltenburg I'm very sorry about the changing from data-player-id to data-player. It really should have been data-player all along to match the non-AMP embed, as you note, which caused some understandable confusion. With this change either can be used to ensure existing pages continue to work, with data-player being preferred in documentation.

[cramforce]

LGTM

[jridgewell]

Ping @erwinmombay: Are we merging this back in?

[erwinmombay]

@jridgewell yep, just waiting on green build again