Add error reporting for broken images

.babelrc

@@ -1,5 +1,20 @@
 {
-  optional: ["utility.inlineEnvironmentVariables"],
-  externalHelpers: true,
-  blacklist: ["regenerator"]
+  "optional": ["utility.inlineEnvironmentVariables"],
+  "externalHelpers": true,
+  "whitelist": [
+    "es3.memberExpressionLiterals",
+    "es3.propertyLiterals",
+    "es5.properties.mutators",
+    "es6.arrowFunctions",
+    "es6.blockScoping",
+    "es6.classes",
+    "es6.constants",
+    "es6.tailCall",
+    "es6.modules",
+    "es6.parameters",
+    "es6.properties.computed",
+    "es6.properties.shorthand",
+    "es6.templateLiterals",
+    "es6.spread"
+  ]
 }

.eslintrc

@@ -1,40 +1,76 @@
 {
   "parser": "babel-eslint",
   "ecmaFeatures": {
+    "modules": true,
     "arrowFunctions": true,
     "blockBindings": true,
-    "forOf": false
+    "forOf": false,
+    "destructuring": false,
+    "spread": false
   },
   "env": {
     "es6": true,
     "browser": true
   },
   "rules": {
-    "semi": 2,
-    "google-camelcase/google-camelcase": 2,
-    "no-eval": 2,
+    "array-bracket-spacing": [2, "never"],
+    "arrow-parens": [2, "as-needed"],
+    "arrow-spacing": 2,
+    "computed-property-spacing": [2, "never"],
     "curly": 2,
-    "radix": 2,
-    "no-debugger": 2,
+    "dot-location": [2, "property"],
+    "eol-last": 2,
+    "google-camelcase/google-camelcase": 2,
+    "indent": [2, 2, { "SwitchCase": 1 }],
+    "key-spacing": 2,
+    "max-len": [2, 80, 4, {
+      "ignoreComments": true,
+      "ignoreUrls": true,
+      "ignorePattern": ""
+    }],
     "no-alert": 2,
+    "no-debugger": 2,
+    "no-div-regex": 2,
+    "no-eval": 2,
     "no-extend-native": 2,
     "no-extra-bind": 2,
+    "no-implicit-coercion": [2, { "boolean": false }],
     "no-implied-eval": 2,
-    "no-native-reassign": 2,
-    "no-lone-blocks": 2,
-    "no-sequences": 2,
-    "no-throw-literal": 2,
-    "no-warning-comments": [2, { "terms": ["do not submit"], "location": "anywhere" }],
-    "wrap-iife": [2, "any"],
-    "no-unused-expressions": 0,
     "no-iterator": 2,
+    "no-lone-blocks": 2,
+    "no-multi-spaces": 2,
+    "no-native-reassign": 2,
     "no-redeclare": 2,
     "no-script-url": 2,
-    "no-implicit-coercion": [2, { "boolean": false }],
-    "no-useless-concat": 2,
     "no-self-compare": 2,
+    "no-sequences": 2,
+    "no-spaced-func": 2,
+    "no-throw-literal": 2,
+    "no-trailing-spaces": 2,
+    "no-unused-expressions": 0,
+    "no-unused-vars": [2, {
+      "argsIgnorePattern": "^var_|opt_|unused",
+      "varsIgnorePattern": "AmpElement|Def|Interface$"
+    }],
     "no-useless-call": 2,
-    "no-div-regex": 2,
-    "max-len": [2, 80, 4, { "ignoreComments": true, "ignoreUrls": false, "ignorePattern": "" }]
+    "no-useless-concat": 2,
+    "no-var": 2,
+    "no-warning-comments": [2, { "terms": ["do not submit"], "location": "anywhere" }],
+    "object-curly-spacing": [2, "never", {
+      "objectsInObjects": false,
+      "arraysInObjects": false
+    }],
+    "prefer-const": 2,
+    "radix": 2,
+    "semi": 2,
+    "space-after-keywords": 2,
+    "space-before-blocks": 2,
+    "space-before-function-paren": [2, "never"],
+    "space-before-keywords": 2,
+    "space-in-parens": 2,
+    "space-infix-ops": 2,
+    "space-unary-ops": [1, { "words": true, "nonwords": false }],
+    "space-return-throw-case": 2,
+    "wrap-iife": [2, "any"]
   }
 }

.gitignore

@@ -1,10 +1,12 @@
 .DS_Store
 .g4ignore
 build
+c
 dist
-dist.ads
 dist.3p
+dist.tools
 examples.build
 examples.min
 node_modules
-npm-debug.log
+npm-debug.log
+.idea

.travis.yml

@@ -1,19 +1,48 @@
 language: node_js
+sudo: required  # See http://docs.travis-ci.com/user/trusty-ci-environment/
+dist: trusty
 node_js:
   - "stable"
+python:
+  - "2.7"
+notifications:
+  webhooks:
+    - http://savage.nonblocking.io:8080/savage/travis
 addons:
+  sauce_connect: true
   hosts:
     - ads.localhost
     - iframe.localhost
+  apt:
+    packages:
+    - protobuf-compiler
+    - python-protobuf
 before_install:
   - export CHROME_BIN=chromium-browser
   - export DISPLAY=:99.0
   - sh -e /etc/init.d/xvfb start
 before_script:
   - npm install -g gulp
+  - pip install --user protobuf
 script:
-  - gulp presubmit
   - gulp lint
   - gulp build
-  - gulp minify
-  - gulp test
+  - gulp dist
+  - gulp presubmit
+  # Unit tests with Travis' default chromium
+  - gulp test --compiled
+  # Integration tests with all saucelabs browsers
+  - gulp test --saucelabs --integration --compiled
+  # All unit tests with an old chrome (best we can do right now to pass tests
+  # and not start relying on new features).
+  # Disabled because it regressed. Better to run the other saucelabs tests.
+  # - gulp test --saucelabs --oldchrome
+  - gulp validator
+branches:
+  only:
+    - master
+    - release
+    - canary
+env:
+  global:
+    - NPM_CONFIG_PROGRESS="false"

3p/README.md

@@ -0,0 +1,63 @@
+# Inclusion of third party software, embeds, and services into AMP
+
+In general all inclusions are subject to [CONTRIBUTING.md](../CONTRIBUTING.md).  This files outlines specific rules for certain types of external embed and other software inclusions.
+
+In order to qualify for inclusion, an extended component that integrates a third-party service must generally meet the notability requirements of the English Wikipedia, and is in common use in Internet publishing.  As a rough rule of thumb, it should be used or requested by 5% of the top 10,000 websites as noted on builtwith.com, or already integrated into [oEmbed](http://oembed.com/).
+
+We highly prefer integrations that do not use iframes. JSONP cannot be used for security reasons, but CORS requests are perfectly fine.
+
+## Embeds
+
+Examples: Youtube, Vimeo videos; Tweets, Instagrams; comment systems; polls; quizzes; document viewers
+
+- Our intent is to provide first class support for all embeds that fulfill the notability guidelines laid out in [CONTRIBUTING.md](../CONTRIBUTING.md).
+- Consider whether a iframe-with-placeholder solution fits your use case where iframe generation is not done immediately (can be done before user action for instant loading of iframe).
+- Consider whether all that is needed is some documentation for how to use the embed with `amp-iframe`.
+- Iframes and all sub resources must be served from HTTPS.
+- Avoid client side rendering of iframe content.
+- If your use of iframes is for style isolation, consider that AMP might provide an iframe-free alternative.
+- If you can make it not-iframe-based that is much better. (See e.g. the pinterest embed). We will always ask to do this first. E.g. adding a CORS endpoint to your server might make this possible.
+- Must play well within [AMP's sizing framework](https://github.com/ampproject/amphtml/blob/master/spec/amp-html-layout.md).
+- All JS on container page must be open source and bundled with AMP.
+- Direct iframe embeds not using our 3p iframe mechanism (used e.g. for ads) are preferred.
+- JavaScript loaded into iframe should be reasonable with respect to functionality.
+- Use the `sandbox` attribute on iframe if possible.
+- Provide unit and integration tests.
+- Embeds that require browser plugins, such as Flash, Java, ActiveX, Silverlight, etc. are disallowed unless necessary. Special review required. We cannot currently see a reason why these should be allowed.
+
+## Ads
+
+- We welcome pull requests by all ad networks for inclusion into AMP.
+- All ads and all sub resources must be served from HTTPS.
+- Must play well within [AMP's sizing framework](https://github.com/ampproject/amphtml/blob/master/spec/amp-html-layout.md).
+- Direct iframe embeds not using our 3p iframe mechanism (used by most ads) are preferred.
+- Providing an optional image only zero-iframe embed is appreciated.
+- Support viewability and other metrics/instrumentation as supplied by AMP (via postMessage API)
+- Try to keep overall iframe count at one per ad. Explain why more are needed.
+- Share JS between iframes on the same page.
+- Provide unit and integration tests.
+- Provide test accounts for inclusion in our open source repository for integration tests.
+
+The following aren't hard requirements, but are performance optimizations we should strive to incorporate. Please provide a timeline as to when you expect to follow these guidelines:
+
+- Support pause and play APIs to turn animations on and off. Ideally also to interrupt loading.
+- Never block the UI thread for longer than 50ms, so that user action is never blocked for longer than that.
+  - Keep individual JS files small enough, so they compile in under 50ms on a 2013 Android phone.
+  - Split up other expensive work, so it can be interrupted at 50ms boundary.
+- Creatives should only use animations drive by CSS animation frame.
+- Creatives should only animate using CSS transforms and opacity.
+- When creatives animate they should not use more than 2ms time per frame to allow for other animations to have sufficient time for concurrent animations.
+
+The better an ad network does on the above requirements, the earlier ads from it will be loaded into AMP. In other words: *The slower the ad loads and the more it interferes with the page, the later AMP will load it.*
+
+We are also excited to start conversations how modern web tech could improve overall ads latency, memory usage and framerate impact and how AMP's open source model could be used to inject trust through an auditable common code base into the ads ecosystem which would reduce the necessity of redundant metrics collection.
+
+Review the [ads/README](../ads/README.md) for further details on ad integration.
+
+## Fonts
+
+- AMP allows inclusion of fonts via the `@font-face` directive.
+- JavaScript can not be involved with the initiation of font loading.
+- Font loading gets controlled (but not initiated) by [`<amp-font>`](https://github.com/ampproject/amphtml/issues/648).
+- AMP by default does not allow inclusion of external stylesheets, but it is happy to whitelist URL prefixes of font providers for font inclusion via link tags. These link tags and their fonts must be served via HTTPS.
+- If a font provider does referrer based "security" it needs to whitelist the AMP proxy origins before being included in the link tag whitelist. AMP proxy sends the appropriate referrer header such as "https://cdn.ampproject.org".