Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] integrates anat and func QA as part of bidsSpatialPrepro #466

Merged
merged 21 commits into from
Jan 10, 2022

Conversation

Remi-Gau
Copy link
Contributor

  • in many places spm_up that is used for anat and func QA requires SPM like filenames (for example with prefixes)
  • this makes it difficult to run anat and func QA after files have been renamd to be BIDS derivatives compatible
  • so a solution is to run them after preprocessing but before renaming

Long term solution would be to refactor spm_up to make it more flexible in terms of inputs, but this would take a long time.


left to do: reslice tissue probability maps to BOLD resolution during preprocessing to allow running all steps of functional QA.

@Remi-Gau Remi-Gau changed the base branch from main to dev January 10, 2022 16:30
@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #466 (1b9c8c7) into dev (8bdbd26) will decrease coverage by 0.58%.
The diff coverage is 25.83%.

❗ Current head 1b9c8c7 differs from pull request most recent head 04a8808. Consider uploading reports for the commit 04a8808 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #466      +/-   ##
==========================================
- Coverage   72.67%   72.09%   -0.59%     
==========================================
  Files         173      175       +2     
  Lines        3444     3505      +61     
==========================================
+ Hits         2503     2527      +24     
- Misses        941      978      +37     
Flag Coverage Δ
unittests 72.09% <25.83%> (-0.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/QA/anatomicalQA.m 0.00% <0.00%> (ø)
src/QA/computeDesignEfficiency.m 54.68% <ø> (ø)
src/QA/functionalQA.m 0.00% <0.00%> (ø)
src/QA/plotEvents.m 45.45% <ø> (ø)
src/batches/preproc/setBatchCoregistrationFmap.m 100.00% <ø> (ø)
src/batches/preproc/setBatchCreateVDMs.m 95.12% <ø> (ø)
src/batches/preproc/setBatchRealign.m 80.00% <ø> (ø)
src/batches/setBatchMeanAnatAndMask.m 100.00% <ø> (ø)
src/fieldmaps/getMetadataFromIntendedForFunc.m 85.71% <ø> (ø)
src/fieldmaps/getTotalReadoutTime.m 75.00% <ø> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bdbd26...04a8808. Read the comment docs.

@Remi-Gau Remi-Gau merged commit 826a0f3 into dev Jan 10, 2022
@Remi-Gau Remi-Gau deleted the remi-update_QA branch January 10, 2022 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant