Support clang tools version 20 #44
Conversation
WalkthroughThe changes update the build workflow and documentation configuration. The build workflow file is renamed and now triggers on a new file path. The matrix strategy is extended to support clang version 20 with an accompanying matrix entry. Additionally, a new step is added to the draft-release job for deleting files larger than 2GB. The README has been updated to reflect these modifications by revising build badge links and adjusting the Clang Tools compatibility table to include clang version 20. Changes
Sequence Diagram(s)sequenceDiagram
participant GH as GitHub Events
participant BuildWF as Build Workflow
participant MatrixJob as Build Job (Matrix)
participant Release as Draft-Release Job
GH->>BuildWF: Trigger on push/PR (build.yml)
BuildWF->>MatrixJob: Execute build matrix (including clang 20)
MatrixJob->>BuildWF: Return build artifacts
BuildWF->>Release: Initiate release steps
Release->>Release: Execute deletion of files >2GB
Possibly related PRs
Suggested labels
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
.github/workflows/build.yml (1)
198-200: New Step: Delete Files Over 2GB
A new draft-release step has been introduced to delete any files larger than 2GB using thefindcommand.
While this helps in managing oversized artifacts, please double-check that the command’s scope does not unintentionally remove critical files. Consider adding logging or a dry-run mode if further safety is desired.README.md (3)
3-3: Commented Out Test Badge
The previously included test badge is now commented out. If it’s no longer needed, consider removing this commented-out line to keep the README clean and avoid confusion.
5-5: Image Alt Text for Platform Badge
The platform badge image on line 5 does not include alternate text (alt text), which is important for accessibility and markdown lint compliance.
Consider updating it as follows:- +🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
5-5: Images should have alternate text (alt text)
null(MD045, no-alt-text)
12-13: Markdown Table Header Column Count
The table header appears to have an extra column due to a trailing pipe, resulting in an inconsistency with the expected 16 columns. This may lead to column misalignment in the rendered table.
Please adjust the header row by removing any superfluous delimiter so that it aligns with the rest of the table rows. For example:-| Clang Tools |OS/Version |20|19|18 |17 |16 |15 |14 |13 |12 |11 |10 |9 |8 |7 | +| Clang Tools | OS/Version | 20 | 19 | 18 | 17 | 16 | 15 | 14 | 13 | 12 | 11 | 10 | 9 | 8 | 7 |Be sure to update the divider row and all subsequent rows accordingly.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/build.yml(3 hunks)README.md(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
README.md
5-5: Images should have alternate text (alt text)
null
(MD045, no-alt-text)
23-23: Table column count
Expected: 16; Actual: 17; Too many cells, extra data will be missing
(MD056, table-column-count)
⏰ Context from checks skipped due to timeout of 90000ms (20)
- GitHub Check: build (10, windows)
- GitHub Check: build (10, macosx)
- GitHub Check: build (10, linux)
- GitHub Check: build (11, windows)
- GitHub Check: build (11, macosx)
- GitHub Check: build (11, linux)
- GitHub Check: build (12, windows)
- GitHub Check: build (12, macosx)
- GitHub Check: build (12, linux)
- GitHub Check: build (12.0.1, windows)
- GitHub Check: build (12.0.1, macosx)
- GitHub Check: build (12.0.1, linux)
- GitHub Check: build (13, windows)
- GitHub Check: build (13, macosx)
- GitHub Check: build (13, linux)
- GitHub Check: build (14, windows)
- GitHub Check: build (14, linux)
- GitHub Check: build (15, windows)
- GitHub Check: build (15, linux)
- GitHub Check: build (16, linux)
🔇 Additional comments (6)
.github/workflows/build.yml (5)
1-1: Workflow Name Update: "Build"
The workflow name has been updated from "Build amd64" to "Build", reflecting the streamlined nature of this configuration.
7-7: Trigger Paths Updated
The trigger paths have been updated to reference the new file path (.github/workflows/build.yml) instead of the old one. This ensures that pushes and pull requests only trigger the intended workflow file.
11-11: Pull Request Trigger Path Adjustment
The pull_request trigger now correctly monitors changes to the updated workflow file, aligning with the push trigger changes.
23-23: Inclusion of Clang Version 20 in Matrix
The matrix strategy has been updated to includeclang-version: [ 20, 19, 18, 17, 16, 15, 14, 13, 12.0.1, 12, 11, 10, 9, 8, 7 ].
This change ensures that clang version 20 is prioritized. Please verify that all conditional expressions (e.g., numeric comparisons like>= 9) correctly handle the new version (an integer 20).
26-27: New Matrix Include Entry for Clang 20
A new entry has been added to the matrix include block for clang version 20 with the corresponding releasellvm-project-20.0.0.src.
This entry correctly maps clang version 20 to its release version.README.md (1)
4-4: Build Badge Link Update
The build badge now correctly points to the new workflow file (build.yml) instead of the oldbuild-amd64.yml. This ensures that the badge reflects the current build status accurately.
Summary by CodeRabbit