-
Notifications
You must be signed in to change notification settings - Fork 2
docs: update readme about clang-tidy #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Caution Review failedThe pull request is closed. WalkthroughThe README documentation was updated to mark clang-tidy versions 19 and 20 as unsupported on macOS 64-bit, changing their status from supported to unsupported. A clarifying note referencing a related GitHub issue was added to explain this change. No code or public API changes were made. Changes
Sequence Diagram(s)Possibly related PRs
Poem
Tip ⚡️ Faster reviews with caching
Enjoy the performance boost—your workflow just got faster. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
README.md (1)
28-29
: Fix capitalization of “macOS” in the note
Apple’s operating system is branded “macOS”, not “MacOS”.
Apply this diff for consistency:- > clang-tidy v19+ failed to run on MacOS (see [issue #51](https://github.com/cpp-linter/clang-tools-static-binaries/issues/51)) + > clang-tidy v19+ failed to run on macOS (see [issue #51](https://github.com/cpp-linter/clang-tools-static-binaries/issues/51))🧰 Tools
🪛 LanguageTool
[grammar] ~28-~28: The operating system from Apple is written “macOS”.
Context: ...OTE] > clang-tidy v19+ failed to run on MacOS (see [issue #51](https://github.com/cpp...(MAC_OS)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
README.md
(2 hunks)
🧰 Additional context used
🪛 LanguageTool
README.md
[grammar] ~28-~28: The operating system from Apple is written “macOS”.
Context: ...OTE] > clang-tidy v19+ failed to run on MacOS (see [issue #51](https://github.com/cpp...
(MAC_OS)
🔇 Additional comments (1)
README.md (1)
19-19
: Verify updated support status for clang-tidy on macOS 64-bit
The change correctly marks clang-tidy v20 and v19 as unsupported (❌) on macOS 64-bit per issue #51. Ensure this aligns with the latest binaries and that no downstream docs or automation rely on these being supported.
fixup of #50
Summary by CodeRabbit