Remove Support v7 (released in May 2019) by February 2025 #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenxianpeng
changed the title
shenxianpeng
changed the title
|
Caution Review failedThe pull request is closed. WalkthroughThis pull request updates GitHub Actions workflows and the README. In both the build and test workflows, clang version 7 is removed from the clang-version matrix. The build workflow now downloads LLVM project files only when clang version is 8. The README has been revised to update the supported Clang tool versions table and includes new notes regarding file sizes and the planned removal of version 7 support by February 2025. Changes
Sequence Diagram(s)sequenceDiagram
participant U as User Commit
participant GH as GitHub Actions
participant W as Build Workflow Runner
U->>GH: Push commit
GH->>W: Trigger build workflow
W->>W: Evaluate clang-version matrix (version 8 active)
alt clang version is 8
W->>W: Download LLVM project files
else clang version ≠ 8
W->>W: Skip LLVM download
end
W->>GH: Execute remaining build steps
sequenceDiagram
participant U as User Commit
participant GH as GitHub Actions
participant W as Test Workflow Runner
U->>GH: Push commit
GH->>W: Trigger test workflow
W->>W: Evaluate clang-version matrix (versions 8 to 20)
W->>W: Download clang binaries & perform tests
W->>GH: Report test results
Possibly related PRs
Suggested labels
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found the following message in this run https://github.com/cpp-linter/clang-tools-static-binaries/actions/runs/13275667377/job/37071217211
##[debug]Failed to download artifact after 1 retries due to ENOSPC: no space left on device, write. Retrying in 5 secondsthis made me think it's time to drop some old version support.
actions/download-artifact#377 (comment)
Summary by CodeRabbit
Chores
Documentation