Merge 0.39.0 RC0 to 0.39.0 #6725
Conversation
`keys parse` uses the global configuration before before client applications have had a chance to apply their settings. This change adds a `GetSealedConfig()` helper that waits for the config to be sealed before returning it. Fixes: #5091 Origin: 4e328d7 Author: Adam Bozanich <adam.boz@gmail.com> Reviewed-by: Alessio Treglia <alessio@tendermint.com>
* launchpad: bump tendermint to v0.33.6 * cha-cha-cha
* launchpad: backport cliCtx.QueryABCI * add prove flag
Include changes from PR #6283 Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Launchpad's Stable Release Managers team's current composition as approved by @okwme (ICF): * @alessio * @clevinson * @ethanfrey
This reverts commit f384592.
Launchpad fix for #6287
Release v0.39.0 - RC0
Codecov Report
@@ Coverage Diff @@
## release/v0.39.0 #6725 +/- ##
==================================================
Coverage ? 51.50%
==================================================
Files ? 337
Lines ? 20619
Branches ? 0
==================================================
Hits ? 10619
Misses ? 9197
Partials ? 803 |
They have been moved to NEWS.md
NEWS.md
Outdated
| @@ -0,0 +1,131 @@ | |||
| # Cosmos-SDK v0.39.0 Release Notes | |||
There was a problem hiding this comment.
Why don't you just call this file RELEASE_NOTES.md?
There was a problem hiding this comment.
The filename was inspired by a naming convention that is wide spread across open source projects https://www.gnu.org/prep/standards/standards.html#NEWS-File
If you feel particularly strongly in favour of renaming this to RELEASE_NOTES.md (or strongly against keeping it as it is), then I'll happily rename it. @clevinson @ethanfrey any thoughts on this?
Please do note that I'm planning to copy and paste the contents in the release I'll publish in Github too anyway :)
There was a problem hiding this comment.
I'm fine either way. Don't have a strong preference. If we are making use of a NEWS file a standard, i would suggest documenting it somewhere in our release procedure, README.md, or CONTRIBUTING.md, so that its clear to users where to find this info.
There was a problem hiding this comment.
I've renamed NEWS.md to RELEASE_NOTES.md. A self-explanatory name is worth 1000s additional lines in CONTRIBUTING.md. Thanks @clevinson!
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Self-explanatory naming convention.
Original pull request: #6791
There was a problem hiding this comment.
tested ACK: https://github.com/ChainSafe/ethermint/pull/386
|
We tested it. It works! |
|
@clevinson ACKed via private message. Releasing now. |
Release v0.39.0
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes